chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm - Issue 7314020: Update UMA user actions parsing, primarily to include WebUI metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

Issue 7314020: Update UMA user actions parsing, primarily to include WebUI metrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update regex Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

index 10cafdb965e672bc513f5cea750ef2145e461005..18176c248bd4f92e09e6d102febeeb06a2998765 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

@@ -131,15 +131,14 @@ const NSUInteger kMaximumMenuPixelsWide = 300;

bookmark_utils::OpenAll(NULL, browser->profile(), browser, node,

disposition);

- const char* metrics_action = NULL;

if (disposition == NEW_FOREGROUND_TAB) {

- metrics_action = "OpenAllBookmarks";

+ UserMetrics::RecordAction(UserMetricsAction("OpenAllBookmarks"));

} else if (disposition == NEW_WINDOW) {

- metrics_action = "OpenAllBookmarksNewWindow";

+ UserMetrics::RecordAction(UserMetricsAction("OpenAllBookmarksNewWindow"));

} else {

- metrics_action = "OpenAllBookmarksIncognitoWindow";

+ UserMetrics::RecordAction(

+ UserMetricsAction("OpenAllBookmarksIncognitoWindow"));

}

- UserMetrics::RecordAction(UserMetricsAction(metrics_action));

}

- (IBAction)openBookmarkMenuItem:(id)sender {

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/webui/options/advanced_options_handler.h » ('j') | no next file with comments »