Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issue 731373003: change roundOut() to take a dst, so we can use that signature to return IRect (Closed)

Created:
6 years, 1 month ago by reed2
Modified:
6 years, 1 month ago
Reviewers:
scroggo, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

change roundOut() to take a dst, so we can use that signature to return IRect BUG=skia: TBR=robertphilips Committed: https://skia.googlesource.com/skia/+/d02cf2664d0e453a6ec57cddc7f09bfc07fd91db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M include/core/SkRect.h View 1 chunk +7 lines, -5 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/731373003/1
6 years, 1 month ago (2014-11-19 01:57:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/d02cf2664d0e453a6ec57cddc7f09bfc07fd91db
6 years, 1 month ago (2014-11-19 02:06:56 UTC) #3
robertphillips
6 years, 1 month ago (2014-11-19 13:32:19 UTC) #5
Message was sent while issue was closed.
This appears to be breaking the Android build.
frameworks/base/libs/hwui/DamageAccumulator.cpp uses the old-style call.

frameworks/base/libs/hwui/DamageAccumulator.cpp: In member function 'void
android::uirenderer::DamageAccumulator::finish(SkRect*)':
frameworks/base/libs/hwui/DamageAccumulator.cpp:225:26: error: no matching
function for call to 'SkRect::roundOut()'
     totalDirty->roundOut();
                          ^
frameworks/base/libs/hwui/DamageAccumulator.cpp:225:26: note: candidates are:
In file included from external/skia/include/core/SkMatrix.h:14:0,
                 from frameworks/base/libs/hwui/DamageAccumulator.h:22,
                 from frameworks/base/libs/hwui/DamageAccumulator.cpp:17:
external/skia/include/core/SkRect.h:799:10: note: void
SkRect::roundOut(SkIRect*) const
     void roundOut(SkIRect* dst) const {
          ^
external/skia/include/core/SkRect.h:799:10: note:   candidate expects 1
argument, 0 provided
external/skia/include/core/SkRect.h:812:10: note: void SkRect::roundOut(SkRect*)
const
     void roundOut(SkRect* dst) const {
          ^
external/skia/include/core/SkRect.h:812:10: note:   candidate expects 1
argument, 0 provided
make: ***
[out/target/product/flounder/obj/SHARED_LIBRARIES/libhwui_intermediates/DamageAccumulator.o]
Error 1

Powered by Google App Engine
This is Rietveld 408576698