net/tools/dump_cache/cache_dumper.cc - Issue 731373002: Enable MSVC warning for unused locals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/dump_cache/cache_dumper.cc

Issue 731373002: Enable MSVC warning for unused locals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Another Windows fix Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/tools/dump_cache/cache_dumper.cc

diff --git a/net/tools/dump_cache/cache_dumper.cc b/net/tools/dump_cache/cache_dumper.cc

index 0ce46a921637062a86a837c97bf1f4699ad4bb3c..99e3dcdc24d2625feaa03fbc2ebd9551a6f95ab2 100644

--- a/net/tools/dump_cache/cache_dumper.cc

+++ b/net/tools/dump_cache/cache_dumper.cc

@@ -45,7 +45,6 @@ bool SafeCreateDirectory(const base::FilePath& path) {

#ifdef WIN32_LARGE_FILENAME_SUPPORT

// Due to large paths on windows, it can't simply do a

// CreateDirectory("a/b/c"). Instead, create each subdirectory manually.

- bool rv = false;

std::wstring::size_type pos(0);

std::wstring backslash(L"\\");