content/renderer/render_font_warmup_win.cc - Issue 731373002: Enable MSVC warning for unused locals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_font_warmup_win.cc

Issue 731373002: Enable MSVC warning for unused locals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_font_warmup_win.cc

diff --git a/content/renderer/render_font_warmup_win.cc b/content/renderer/render_font_warmup_win.cc

index effdea4bc53e0066b6401ab410c646c7b9f77684..3fc90f19003015587b0a97bd13d53e92c4165f9b 100644

--- a/content/renderer/render_font_warmup_win.cc

+++ b/content/renderer/render_font_warmup_win.cc

@@ -191,7 +191,7 @@ SkFontMgr* GetPreSandboxWarmupFontMgr() {

IDWriteFactory* factory;

CreateDirectWriteFactory(&factory);

- IDWriteFontCollection* collection = GetCustomFontCollection(factory);

+ GetCustomFontCollection(factory);

Peter Kasting 2014/11/18 00:41:03 I assumed calling this was important to warm up so

PatchDWriteFactory(factory);