chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc - Issue 731373002: Enable MSVC warning for unused locals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

Issue 731373002: Enable MSVC warning for unused locals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/enumerate_modules_model_win.cc ('k') | chrome/browser/extensions/external_provider_impl.cc » ('j') | chrome/browser/extensions/external_provider_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

diff --git a/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc b/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

index eafd73017cb914fa42dc730f4c11dc30666b75d0..08f30be7461084531c6a1d1779596ec3699b2eb8 100644

--- a/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

+++ b/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

@@ -336,10 +336,9 @@ IN_PROC_BROWSER_TEST_F(BrowserActionInteractiveTest,

EXPECT_EQ(TRUE, ::IsWindow(hwnd));

// Create a new browser window to prevent the message loop from terminating.

- Browser* new_browser = chrome::FindBrowserWithWebContents(

- browser()->OpenURL(content::OpenURLParams(

- GURL("about:"), content::Referrer(), NEW_WINDOW,

- ui::PAGE_TRANSITION_TYPED, false)));

+ browser()->OpenURL(content::OpenURLParams(GURL("about:"), content::Referrer(),

+ NEW_WINDOW,

+ ui::PAGE_TRANSITION_TYPED, false));

// Forcibly closing the browser HWND should not cause a crash.

EXPECT_EQ(TRUE, ::CloseWindow(hwnd));