Enable MSVC warning for unused locals.

cloud_print/service/win/cloud_print_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// Work around warning in atlbase.h
+// https://connect.microsoft.com/VisualStudio/feedback/details/1032199/atlbase-h-gives-warning-c4189-when-compiling-with-atl-no-com-support
+#pragma warning(push)
+#pragma warning(disable:4189)
 #include <atlbase.h>
+#pragma warning(pop)
 #include <security.h>
 
 #include <iomanip>
 #include <iostream>
 #include <iterator>
 #include <string>
 #include <vector>
 
 #include "base/at_exit.h"
 #include "base/bind.h"
@@ skipping 311 matching lines @@
     *printers = setup.printers();
     return S_OK;
   }
 
   HRESULT SetupServiceState(const base::FilePath& user_data_dir,
                             const std::vector<std::string>& printers) {
     base::FilePath file = user_data_dir.Append(chrome::kServiceStateFileName);
 
     std::string contents;
     ServiceState service_state;
+    if (!base::ReadFileToString(file, &contents) ||
+        !service_state.FromString(contents)) {

[Vitaly Buka (NO REVIEWS), 2014/11/18 19:35:56]

please don't return error. that was just unused war.
it's OK if file is missing
code here just needs to get proxy_id if it's there from previous run, and
rewrite new settings.

[Peter Kasting, 2014/11/18 20:45:31]

OK, removed error handling.

+      return ReportError(E_FAIL, IDS_ERROR_FAILED_CREATE_CONFIG);
+    }
 
-    bool is_valid = base::ReadFileToString(file, &contents) &&
-                    service_state.FromString(contents);
     std::string proxy_id = service_state.proxy_id();
 
     LOG(INFO) << file.value() << ": " << contents;
 
     base::string16 message =
         cloud_print::LoadLocalString(IDS_ADD_PRINTERS_USING_CHROME);
     std::cout << "\n" << message.c_str() << "\n" ;
     std::string new_contents =
         ChromeLauncher::CreateServiceStateFile(proxy_id, printers);
 
@@ skipping 61 matching lines @@
   settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG;
   logging::InitLogging(settings);
 
   logging::SetMinLogLevel(
       CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableLogging) ?
       logging::LOG_INFO : logging::LOG_FATAL);
 
   return _AtlModule.WinMain(0);
 }