Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 731293006: Implement style invalidation tracking (Closed)

Created:
6 years ago by pdr.
Modified:
6 years ago
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Implement style invalidation tracking This patch wires up style invalidation tracking with support for tracking invalidations created by the style invalidator. The goal of this patch is to connect ScheduleStyleInvalidationTracking (which has stacktrace, changedId, invalidationSet, etc.) and StyleInvalidatorInvalidationTracking (which has reason, invalidationList, and selectorPart). Instead of showing these details to the user we synthesize StyleRecalcInvalidationTracking events from the above data. The major changes in this patch are to add the two new events (ScheduleStyleInvalidationTracking, StyleInvalidatorInvalidationTracking) and wire up their logic and UI. A screenshot of a Google query for science is at: http://pr.gg/inv34.png (The wording will all change very soon so "Element is pending an invalidation list" will change to something like "Style system invalidated") I've added a new mechanism for dumping invalidation data and used it in this patch. The other invalidation tests will be switched to this approach in a followup patch. BUG=410701 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186394

Patch Set 1 #

Patch Set 2 : Three equals #

Patch Set 3 : More tests #

Total comments: 15

Patch Set 4 : Address reviewer comments, cleanup #

Messages

Total messages: 12 (4 generated)
pdr.
@Kouhei, would you please take a look? @devtools folks, this isn't quite ready for a ...
6 years ago (2014-12-01 05:26:39 UTC) #3
pdr.
On 2014/12/01 at 23:17:54, pdr wrote: > pdr@chromium.org changed reviewers: > + caseq@chromium.org, yurys@chromium.org Ok, ...
6 years ago (2014-12-01 23:18:09 UTC) #5
kouhei (in TOK)
lgtm
6 years ago (2014-12-02 01:30:17 UTC) #6
caseq
https://codereview.chromium.org/731293006/diff/40001/LayoutTests/inspector/tracing/timeline-paint-and-multiple-style-invalidations.html File LayoutTests/inspector/tracing/timeline-paint-and-multiple-style-invalidations.html (right): https://codereview.chromium.org/731293006/diff/40001/LayoutTests/inspector/tracing/timeline-paint-and-multiple-style-invalidations.html#newcode25 LayoutTests/inspector/tracing/timeline-paint-and-multiple-style-invalidations.html:25: InspectorTest.runTestSuite([ do you need a suite here? https://codereview.chromium.org/731293006/diff/40001/LayoutTests/inspector/tracing/timeline-paint-and-multiple-style-invalidations.html#newcode28 LayoutTests/inspector/tracing/timeline-paint-and-multiple-style-invalidations.html:28: ...
6 years ago (2014-12-02 14:59:42 UTC) #7
pdr.
https://codereview.chromium.org/731293006/diff/40001/LayoutTests/inspector/tracing/timeline-paint-and-multiple-style-invalidations.html File LayoutTests/inspector/tracing/timeline-paint-and-multiple-style-invalidations.html (right): https://codereview.chromium.org/731293006/diff/40001/LayoutTests/inspector/tracing/timeline-paint-and-multiple-style-invalidations.html#newcode25 LayoutTests/inspector/tracing/timeline-paint-and-multiple-style-invalidations.html:25: InspectorTest.runTestSuite([ On 2014/12/02 at 14:59:42, caseq wrote: > do ...
6 years ago (2014-12-03 04:33:53 UTC) #8
caseq
lgtm
6 years ago (2014-12-03 07:18:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/731293006/60001
6 years ago (2014-12-03 07:19:08 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-03 08:58:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186394

Powered by Google App Engine
This is Rietveld 408576698