Add command line and flag option to force 2D canvas to use display lists

Add command line and flag option to force 2D canvas to use display lists

BUG=386601
Committed: https://crrev.com/9763de263416abbb72ddd50783401ac78289bd13
Cr-Commit-Position: refs/heads/master@{#304793}

[Sergey, 2014-11-18 01:25:35]

p.sergey@samsung.com changed reviewers:
+ junov@chromium.org

[Sergey, 2014-11-18 01:27:18]

PTAL. Want to use 'force' option from command line and/or chrome:flags.

[Justin Novosad, 2014-11-18 15:38:28]

On 2014/11/18 01:27:18, Sergey wrote:
> PTAL. Want to use 'force' option from command line and/or chrome:flags.

'Force' is not something we plan to expose as an experiment, we just want to
make it available for testing/debugging purposes, so I would rather we not
expose this in about:flags.    So please revert generated_resources.grd and
about_flags.cc.  I am fine with the rest of this change.

Otherwise LGTM, but I am not an OWNER.

[Justin Novosad, 2014-11-18 15:39:00]

junov@chromium.org changed reviewers:
+ avi@chromium.org

[Justin Novosad, 2014-11-18 15:39:01]

+avi for owner's approval

[Avi (use Gerrit), 2014-11-18 15:42:10]

On 2014/11/18 15:39:01, junov wrote:
> +avi for owner's approval

I don't understand what "forced" means in the context of "enabled"/"disabled".

[Justin Novosad, 2014-11-18 15:51:16]

On 2014/11/18 15:42:10, Avi wrote:
> On 2014/11/18 15:39:01, junov wrote:
> > +avi for owner's approval
> 
> I don't understand what "forced" means in the context of "enabled"/"disabled".

Good point. Sergey, can you add comments to content_switches.cc to explain:
Enable -> allow browser to use display lists for 2D canvas (browser makes
decision)
Force -> browser always uses display lists for 2D canvas.

[Avi (use Gerrit), 2014-11-18 16:17:42]

On 2014/11/18 15:51:16, junov wrote:
> On 2014/11/18 15:42:10, Avi wrote:
> > On 2014/11/18 15:39:01, junov wrote:
> > > +avi for owner's approval
> > 
> > I don't understand what "forced" means in the context of
"enabled"/"disabled".
> 
> Good point. Sergey, can you add comments to content_switches.cc to explain:
> Enable -> allow browser to use display lists for 2D canvas (browser makes
> decision)
> Force -> browser always uses display lists for 2D canvas.

Oh! That makes sense now.

Yes. This LGTM, but only if you put an explanation like that in there.

[Sergey, 2014-11-19 01:45:02]

Thank you for reviews.

Please, check that you are fine with the comments I've added and I will commit.

[Avi (use Gerrit), 2014-11-19 01:49:01]

lgtm

https://codereview.chromium.org/731293004/diff/20001/content/public/common/co...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/731293004/diff/20001/content/public/common/co...
content/public/common/content_switches.cc:343: // Enables display list based 2d
canvas implementation. Options:
s/2d/2D/ ?

[Sergey, 2014-11-19 01:59:56]

Patchset #3 (id:40001) has been deleted

[Sergey, 2014-11-19 02:01:18]

https://codereview.chromium.org/731293004/diff/20001/content/public/common/co...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/731293004/diff/20001/content/public/common/co...
content/public/common/content_switches.cc:343: // Enables display list based 2d
canvas implementation. Options:
On 2014/11/19 01:49:01, Avi wrote:
> s/2d/2D/ ?

2d.
Let is be no 's'.

[Sergey, 2014-11-19 02:01:43]

The CQ bit was checked by p.sergey@samsung.com

[commit-bot: I haz the power, 2014-11-19 02:02:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/731293004/60001

[commit-bot: I haz the power, 2014-11-19 02:09:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-19 02:09:07]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sergey, 2014-11-19 02:38:55]

p.sergey@samsung.com changed reviewers:
+ nkostylev@chromium.org

[Sergey, 2014-11-19 02:39:50]

On 2014/11/19 02:09:07, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Missing LGTM from an OWNER for these files:
    chrome/browser/chromeos/login/chrome_restart_request.cc

Nikita, PTAL.

[Nikita (slow), 2014-11-19 09:43:07]

lgtm

feel free to TBR such changes.

[Sergey, 2014-11-19 10:48:23]

The CQ bit was checked by p.sergey@samsung.com

[commit-bot: I haz the power, 2014-11-19 10:49:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/731293004/60001

[commit-bot: I haz the power, 2014-11-19 10:51:01]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2014-11-19 10:51:47]

Patchset 3 (id:??) landed as
https://crrev.com/9763de263416abbb72ddd50783401ac78289bd13
Cr-Commit-Position: refs/heads/master@{#304793}