Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: examples/apptest/example_service_application.h

Issue 731293003: Use Binding instead of InterfaceImpl for ExampleService. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Simplify ExampleClientImpl. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: examples/apptest/example_service_application.h
diff --git a/examples/apptest/example_service_application.h b/examples/apptest/example_service_application.h
index 301895f5fe2727b6e29eaf76d873514117ee7971..b995edcfd2c64a821b3df27d00da8c86e4985b49 100644
--- a/examples/apptest/example_service_application.h
+++ b/examples/apptest/example_service_application.h
@@ -7,24 +7,27 @@
#include "examples/apptest/example_service_impl.h"
#include "mojo/public/cpp/application/application_delegate.h"
-#include "mojo/public/cpp/application/interface_factory_impl.h"
+#include "mojo/public/cpp/application/interface_factory.h"
#include "mojo/public/cpp/system/macros.h"
namespace mojo {
class ApplicationConnection;
-class ExampleServiceApplication : public ApplicationDelegate {
+class ExampleServiceApplication : public ApplicationDelegate,
+ public InterfaceFactory<ExampleService> {
public:
ExampleServiceApplication();
- virtual ~ExampleServiceApplication();
+ ~ExampleServiceApplication() override;
private:
// ApplicationDelegate implementation.
- virtual bool ConfigureIncomingConnection(
+ bool ConfigureIncomingConnection(
ApplicationConnection* connection) override;
- InterfaceFactoryImpl<ExampleServiceImpl> example_service_factory_;
msw 2014/11/17 21:42:36 Question: Do we want an InterfaceFactory implement
jamesr 2014/11/17 22:33:04 Maybe. I think the way to evaluate whether helpers
msw 2014/11/17 23:05:32 Acknowledged, I'll hold off on this.
+ // InterfaceFactory<ExampleService> implementation.
+ void Create(ApplicationConnection* connection,
+ InterfaceRequest<ExampleService> request) override;
MOJO_DISALLOW_COPY_AND_ASSIGN(ExampleServiceApplication);
};

Powered by Google App Engine
This is Rietveld 408576698