Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: Source/core/rendering/svg/RenderSVGContainer.h

Issue 731243002: Move m_paintInvalidationBoundingBox into RenderSVGModelObject (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Drop bitfield. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/rendering/svg/RenderSVGImage.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) 2009 Google, Inc. All rights reserved. 4 * Copyright (C) 2009 Google, Inc. All rights reserved.
5 * Copyright (C) 2009 Apple Inc. All rights reserved. 5 * Copyright (C) 2009 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 29 matching lines...) Expand all
40 void slowLastChild() const WTF_DELETED_FUNCTION; 40 void slowLastChild() const WTF_DELETED_FUNCTION;
41 41
42 RenderObject* firstChild() const { ASSERT(children() == virtualChildren()); return children()->firstChild(); } 42 RenderObject* firstChild() const { ASSERT(children() == virtualChildren()); return children()->firstChild(); }
43 RenderObject* lastChild() const { ASSERT(children() == virtualChildren()); r eturn children()->lastChild(); } 43 RenderObject* lastChild() const { ASSERT(children() == virtualChildren()); r eturn children()->lastChild(); }
44 44
45 virtual void paint(PaintInfo&, const LayoutPoint&) override; 45 virtual void paint(PaintInfo&, const LayoutPoint&) override;
46 virtual void setNeedsBoundariesUpdate() override final { m_needsBoundariesUp date = true; } 46 virtual void setNeedsBoundariesUpdate() override final { m_needsBoundariesUp date = true; }
47 virtual bool didTransformToRootUpdate() { return false; } 47 virtual bool didTransformToRootUpdate() { return false; }
48 bool isObjectBoundingBoxValid() const { return m_objectBoundingBoxValid; } 48 bool isObjectBoundingBoxValid() const { return m_objectBoundingBoxValid; }
49 49
50 virtual FloatRect paintInvalidationRectInLocalCoordinates() const override f inal { return m_paintInvalidationBoundingBox; }
51 bool selfWillPaint(); 50 bool selfWillPaint();
52 51
53 protected: 52 protected:
54 virtual RenderObjectChildList* virtualChildren() override final { return chi ldren(); } 53 virtual RenderObjectChildList* virtualChildren() override final { return chi ldren(); }
55 virtual const RenderObjectChildList* virtualChildren() const override final { return children(); } 54 virtual const RenderObjectChildList* virtualChildren() const override final { return children(); }
56 55
57 virtual bool isOfType(RenderObjectType type) const override { return type == RenderObjectSVGContainer || RenderSVGModelObject::isOfType(type); } 56 virtual bool isOfType(RenderObjectType type) const override { return type == RenderObjectSVGContainer || RenderSVGModelObject::isOfType(type); }
58 virtual const char* renderName() const override { return "RenderSVGContainer "; } 57 virtual const char* renderName() const override { return "RenderSVGContainer "; }
59 58
60 virtual void layout() override; 59 virtual void layout() override;
(...skipping 17 matching lines...) Expand all
78 virtual void determineIfLayoutSizeChanged() { } 77 virtual void determineIfLayoutSizeChanged() { }
79 78
80 void updateCachedBoundaries(); 79 void updateCachedBoundaries();
81 80
82 private: 81 private:
83 const RenderObjectChildList* children() const { return &m_children; } 82 const RenderObjectChildList* children() const { return &m_children; }
84 RenderObjectChildList* children() { return &m_children; } 83 RenderObjectChildList* children() { return &m_children; }
85 84
86 RenderObjectChildList m_children; 85 RenderObjectChildList m_children;
87 FloatRect m_objectBoundingBox; 86 FloatRect m_objectBoundingBox;
87 FloatRect m_strokeBoundingBox;
88 bool m_objectBoundingBoxValid; 88 bool m_objectBoundingBoxValid;
89 FloatRect m_strokeBoundingBox; 89 bool m_needsBoundariesUpdate;
90 FloatRect m_paintInvalidationBoundingBox;
91 bool m_needsBoundariesUpdate : 1;
92 }; 90 };
93 91
94 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderSVGContainer, isSVGContainer()); 92 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderSVGContainer, isSVGContainer());
95 93
96 } // namespace blink 94 } // namespace blink
97 95
98 #endif // RenderSVGContainer_h 96 #endif // RenderSVGContainer_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/rendering/svg/RenderSVGImage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698