Index: tools/telemetry/telemetry/value/trace.py |
diff --git a/tools/telemetry/telemetry/value/trace.py b/tools/telemetry/telemetry/value/trace.py |
index 643f51578fd0bd02bd99b1eeaaba4144f112a63e..b85751c9aed78d940c06b8f97918ff3d6ca8cf13 100644 |
--- a/tools/telemetry/telemetry/value/trace.py |
+++ b/tools/telemetry/telemetry/value/trace.py |
@@ -50,6 +50,10 @@ class TraceValue(value_module.Value): |
page_name = None |
return 'TraceValue(%s, %s)' % (page_name, self.name) |
+ @property |
+ def cloud_url(self): |
nednguyen
2014/11/20 18:46:53
This doesn't need to be exposed. If pylint complai
Yufeng Shen (Slow to review)
2014/11/20 19:13:35
Done.
|
+ return self._cloud_url |
+ |
def GetBuildbotDataType(self, output_context): |
return None |
@@ -82,6 +86,8 @@ class TraceValue(value_module.Value): |
def AsDict(self): |
d = super(TraceValue, self).AsDict() |
d['file_id'] = self._file_handle.id |
+ if self._cloud_url: |
+ d['cloud_url'] = self.cloud_url |
return d |
def UploadToCloud(self, bucket): |
@@ -97,6 +103,7 @@ class TraceValue(value_module.Value): |
sys.stderr.write( |
'View generated trace files online at %s for page %s\n' % |
(self._cloud_url, self.page.url if self.page else 'unknown')) |
+ return self._cloud_url |
except cloud_storage.PermissionError as e: |
logging.error('Cannot upload trace files to cloud storage due to ' |
' permission error: %s' % e.message) |