Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: tools/telemetry/telemetry/results/page_test_results.py

Issue 731233003: Format profiler/trace files cloud url (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ready to submit Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/results/page_test_results_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/results/page_test_results.py
diff --git a/tools/telemetry/telemetry/results/page_test_results.py b/tools/telemetry/telemetry/results/page_test_results.py
index fe01c0be1a1655644e38814eeaddc64df74474b8..9ccd2b7a6c738b1918a7962f5fd8091d7531df0f 100644
--- a/tools/telemetry/telemetry/results/page_test_results.py
+++ b/tools/telemetry/telemetry/results/page_test_results.py
@@ -189,10 +189,16 @@ class PageTestResults(object):
values.append(value)
return values
- def UploadTraceFilesToCloud(self, bucket):
+ def FindAllTraceValues(self):
+ values = []
for value in self.all_page_specific_values:
if isinstance(value, trace.TraceValue):
- value.UploadToCloud(bucket)
+ values.append(value)
+ return values
+
+ def UploadTraceFilesToCloud(self, bucket):
+ for value in self.FindAllTraceValues():
+ value.UploadToCloud(bucket)
def UploadProfilingFilesToCloud(self, bucket):
for page, file_handle_list in self._pages_to_profiling_files.iteritems():
« no previous file with comments | « no previous file | tools/telemetry/telemetry/results/page_test_results_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698