Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: tools/telemetry/telemetry/value/trace_unittest.py

Issue 731233003: Format profiler/trace files cloud url (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Do not format profiler value Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import os 5 import os
6 import unittest 6 import unittest
7 7
8 from telemetry.page import page_set 8 from telemetry.page import page_set
9 from telemetry.timeline import tracing_timeline_data 9 from telemetry.timeline import tracing_timeline_data
10 from telemetry.unittest_util import system_stub
10 from telemetry.value import trace 11 from telemetry.value import trace
11 12
12 class TestBase(unittest.TestCase): 13 class TestBase(unittest.TestCase):
13 def setUp(self): 14 def setUp(self):
14 self.page_set = page_set.PageSet(file_path=os.path.dirname(__file__)) 15 self.page_set = page_set.PageSet(file_path=os.path.dirname(__file__))
15 self.page_set.AddPageWithDefaultRunNavigate("http://www.bar.com/") 16 self.page_set.AddPageWithDefaultRunNavigate("http://www.bar.com/")
16 self.page_set.AddPageWithDefaultRunNavigate("http://www.baz.com/") 17 self.page_set.AddPageWithDefaultRunNavigate("http://www.baz.com/")
17 self.page_set.AddPageWithDefaultRunNavigate("http://www.foo.com/") 18 self.page_set.AddPageWithDefaultRunNavigate("http://www.foo.com/")
18 19
20 self._cloud_storage_stub = None
21
22 def tearDown(self):
23 if self._cloud_storage_stub:
24 self._cloud_storage_stub.Restore()
25 self._cloud_storage_stub = None
26
27 def StubCloudStorage(self):
nednguyen 2014/11/20 18:46:53 just make this setUp(self):
Yufeng Shen (Slow to review) 2014/11/20 19:13:35 Done.
28 self._cloud_storage_stub = system_stub.Override(trace, ['cloud_storage'])
29
19 @property 30 @property
20 def pages(self): 31 def pages(self):
21 return self.page_set.pages 32 return self.page_set.pages
22 33
23 class ValueTest(TestBase): 34 class ValueTest(TestBase):
24 def testAsDict(self): 35 def testAsDict(self):
36 self.StubCloudStorage()
25 v = trace.TraceValue( 37 v = trace.TraceValue(
26 None, tracing_timeline_data.TracingTimelineData({'test' : 1})) 38 None, tracing_timeline_data.TracingTimelineData({'test' : 1}))
27 fh_id = v.GetAssociatedFileHandle().id 39 fh = v.GetAssociatedFileHandle()
28 40 trace.cloud_storage.SetCalculatedHashesForTesting(
41 {fh.GetAbsPath(): None, })
nednguyen 2014/11/20 18:46:53 Can you use some random value rather than None?
Yufeng Shen (Slow to review) 2014/11/20 19:13:35 Done.
42 bucket = trace.cloud_storage.PUBLIC_BUCKET
43 cloud_url = v.UploadToCloud(bucket)
29 d = v.AsDict() 44 d = v.AsDict()
30 45 self.assertEqual(d['file_id'], fh.id)
31 self.assertEqual(d['file_id'], fh_id) 46 self.assertEqual(d['cloud_url'], cloud_url)
OLDNEW
« tools/telemetry/telemetry/value/trace.py ('K') | « tools/telemetry/telemetry/value/trace.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698