Format profiler/trace files cloud url

tools/telemetry/telemetry/results/page_test_results.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import copy
 import datetime
 import itertools
 import logging
 import random
@@ skipping 171 matching lines @@
         values.append(value)
     return values
 
   def FindAllPageSpecificValuesNamed(self, value_name):
     values = []
     for value in self.all_page_specific_values:
       if value.name == value_name:
         values.append(value)
     return values
 
+  def FindAllTraceValues(self):
+    values = []
+    for value in self.all_page_specific_values:
+      if isinstance(value, trace.TraceValue):
+        values.append(value)
+    return values
+
   def UploadTraceFilesToCloud(self, bucket):
-    for value in self.all_page_specific_values:
-      if isinstance(value, trace.TraceValue):
-        value.UploadToCloud(bucket)
+    for value in self.FindAllTraceValues():
+      value.UploadToCloud(bucket)
 
   def UploadProfilingFilesToCloud(self, bucket):
     for page, file_handle_list in self._pages_to_profiling_files.iteritems():
       for file_handle in file_handle_list:
         remote_path = ('profiler-file-id_%s-%s%-d%s' % (
             file_handle.id,
             datetime.datetime.now().strftime('%Y-%m-%d_%H-%M-%S'),
             random.randint(1, 100000),
             file_handle.extension))
         try:
           cloud_url = cloud_storage.Insert(
               bucket, remote_path, file_handle.GetAbsPath())
           sys.stderr.write(
               'View generated profiler files online at %s for page %s\n' %
               (cloud_url, page.display_name))
           self._pages_to_profiling_files_cloud_url[page].append(cloud_url)
         except cloud_storage.PermissionError as e:
           logging.error('Cannot upload profiling files to cloud storage due to '
                         ' permission error: %s' % e.message)