Refactoring: Change all -FileUtils non-Singleton and to own underlying FileUtils.

Refactoring: Change all -FileUtils non-Singleton and to own underlying FileUtils.

Based on the discussion at http://codereview.chromium.org/7174002/diff/26001/webkit/fileapi/local_file_system_file_util.h#newcode38, this change
* also reduces dependency between FileUtils,
* enables more flexible stacking of -FileUtils, such as QuotaFileUtil over other -FileUtils, and
* makes -FileUtils symmetry so owner handling for these objects gets unified.


BUG=none
TEST=FileSystemFileUtilTest.*,FileSystemOperationTest.*,FileSystemOperationWriteTest.*,FileSystemQuotaTest.*,FileWriterDelegateTest.*,LocalFileSystemFileUtilTest.*,ObfuscatedFileSystemFileUtil.*,QuotaFileUtil.*,SandboxMountPointProviderTest.*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94251

[Dai Mikurube (NOT FULLTIME), 2011-07-08 07:55:35]

This patch is to change all FileUtils (including FileSystemFileUtil and
QuotaFileUtil) non-SIngleton.

Their underlying FileUtils are now owned by them.

[Dai Mikurube (NOT FULLTIME), 2011-07-11 06:49:45]

Updated.

[Dai Mikurube (NOT FULLTIME), 2011-07-26 04:58:06]

Updated.

[kinuko, 2011-07-26 06:00:35]

Could we file a bug and have a brief bigger plan in it (like the ones you noted
on owp-storage sites, but in a bit more organized way)?  This changeset looks
innocent but without a context it might be hard to see why this change is being
made.

http://codereview.chromium.org/7312023/diff/14001/webkit/fileapi/quota_file_u...
File webkit/fileapi/quota_file_util.cc (right):

http://codereview.chromium.org/7312023/diff/14001/webkit/fileapi/quota_file_u...
webkit/fileapi/quota_file_util.cc:81: QuotaFileUtil* QuotaFileUtil::GetDefault()
{
Please make the method name obvious that it creates a new instance.

[Dai Mikurube (NOT FULLTIME), 2011-07-26 06:52:46]

Thank you.

This change is a kind of independent from the bigger plan of refactoring (it's
based on the discussion at
http://codereview.chromium.org/7174002/diff/26001/webkit/fileapi/local_file_s...),
I've added a brief description in this change.

http://codereview.chromium.org/7312023/diff/14001/webkit/fileapi/quota_file_u...
File webkit/fileapi/quota_file_util.cc (right):

http://codereview.chromium.org/7312023/diff/14001/webkit/fileapi/quota_file_u...
webkit/fileapi/quota_file_util.cc:81: QuotaFileUtil* QuotaFileUtil::GetDefault()
{
On 2011/07/26 06:00:35, kinuko wrote:
> Please make the method name obvious that it creates a new instance.

Done.

[kinuko, 2011-07-26 09:48:57]

lgtm except for nits

http://codereview.chromium.org/7312023/diff/15003/webkit/fileapi/quota_file_u...
File webkit/fileapi/quota_file_util.h (right):

http://codereview.chromium.org/7312023/diff/15003/webkit/fileapi/quota_file_u...
webkit/fileapi/quota_file_util.h:17: static const int64 kNoLimit;
style-nit: place variables after methods

http://codereview.chromium.org/7312023/diff/15003/webkit/fileapi/quota_file_u...
webkit/fileapi/quota_file_util.h:26: static QuotaFileUtil* CreateDefault();
Please add comment about what this does.  The comment above says this can be
instantiated by 'new' operator while we have static Create method, which would
confuse the reader.

[Dai Mikurube (NOT FULLTIME), 2011-07-26 10:19:11]

http://codereview.chromium.org/7312023/diff/15003/webkit/fileapi/quota_file_u...
File webkit/fileapi/quota_file_util.h (right):

http://codereview.chromium.org/7312023/diff/15003/webkit/fileapi/quota_file_u...
webkit/fileapi/quota_file_util.h:17: static const int64 kNoLimit;
On 2011/07/26 09:48:57, kinuko wrote:
> style-nit: place variables after methods

I remember Constants (static const) are better to be located before methods.

http://codereview.chromium.org/7312023/diff/15003/webkit/fileapi/quota_file_u...
webkit/fileapi/quota_file_util.h:26: static QuotaFileUtil* CreateDefault();
On 2011/07/26 09:48:57, kinuko wrote:
> Please add comment about what this does.  The comment above says this can be
> instantiated by 'new' operator while we have static Create method, which would
> confuse the reader.

Done.

[kinuko, 2011-07-27 03:28:20]

still lgtm just in case you're waiting another one.

On 2011/07/26 10:19:11, Dai Mikurube wrote:
>
http://codereview.chromium.org/7312023/diff/15003/webkit/fileapi/quota_file_u...
> File webkit/fileapi/quota_file_util.h (right):
> 
>
http://codereview.chromium.org/7312023/diff/15003/webkit/fileapi/quota_file_u...
> webkit/fileapi/quota_file_util.h:17: static const int64 kNoLimit;
> On 2011/07/26 09:48:57, kinuko wrote:
> > style-nit: place variables after methods
> 
> I remember Constants (static const) are better to be located before methods.

Yup, you're right!

>
http://codereview.chromium.org/7312023/diff/15003/webkit/fileapi/quota_file_u...
> webkit/fileapi/quota_file_util.h:26: static QuotaFileUtil* CreateDefault();
> On 2011/07/26 09:48:57, kinuko wrote:
> > Please add comment about what this does.  The comment above says this can be
> > instantiated by 'new' operator while we have static Create method, which
would
> > confuse the reader.
> 
> Done.

[Dai Mikurube (NOT FULLTIME), 2011-07-27 03:50:31]

Thanks, I've checked "Commit"!

On 2011/07/27 03:28:20, kinuko wrote:
> still lgtm just in case you're waiting another one.
> 
> On 2011/07/26 10:19:11, Dai Mikurube wrote:
> >
>
http://codereview.chromium.org/7312023/diff/15003/webkit/fileapi/quota_file_u...
> > File webkit/fileapi/quota_file_util.h (right):
> > 
> >
>
http://codereview.chromium.org/7312023/diff/15003/webkit/fileapi/quota_file_u...
> > webkit/fileapi/quota_file_util.h:17: static const int64 kNoLimit;
> > On 2011/07/26 09:48:57, kinuko wrote:
> > > style-nit: place variables after methods
> > 
> > I remember Constants (static const) are better to be located before methods.
> 
> Yup, you're right!
> 
> >
>
http://codereview.chromium.org/7312023/diff/15003/webkit/fileapi/quota_file_u...
> > webkit/fileapi/quota_file_util.h:26: static QuotaFileUtil* CreateDefault();
> > On 2011/07/26 09:48:57, kinuko wrote:
> > > Please add comment about what this does.  The comment above says this can
be
> > > instantiated by 'new' operator while we have static Create method, which
> would
> > > confuse the reader.
> > 
> > Done.

[commit-bot: I haz the power, 2011-07-27 06:06:45]

Change committed as 94251