Issue 731173002: Revert "move SkPDFD*.h from include to src"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 731173002: Revert "move SkPDFD*.h from include to src" (Closed)

Created:
6 years, 1 month ago by humper

Modified:
6 years, 1 month ago

Reviewers:
hal.canary

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert "move SkPDFD*.h from include to src" This reverts commit 693024300f79ff3fb497ddee1043b609ddf521a4. was breaking canary build BUG=skia: Committed: https://skia.googlesource.com/skia/+/21c771b3fc827fa4d3e3ca337385870b50b81ff6

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -467 lines)			Patch
M	gm/gmmain.cpp	View	3 chunks	+50 lines, -12 lines	0 comments	Download
M	gyp/pdf.gyp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	gyp/pdf.gypi	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	gyp/tools.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	include/pdf/SkPDFDevice.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	include/pdf/SkPDFDocument.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	src/pdf/SkPDFDevice.h	View	1 chunk	+0 lines, -341 lines	0 comments	Download
D	src/pdf/SkPDFDocument.h	View	1 chunk	+0 lines, -113 lines	0 comments	Download

Total messages: 2 (1 generated)

humper

6 years, 1 month ago (2014-11-17 14:42:30 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
21c771b3fc827fa4d3e3ca337385870b50b81ff6 (presubmit successful).