Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 731143004: Revert of Remove calls to deprecated SkPDFDevice and SkPDFDocuemnt. (Closed)

Created:
6 years, 1 month ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, djsollen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove calls to deprecated SkPDFDevice and SkPDFDocuemnt. (patchset #4 id:370001 of https://codereview.chromium.org/694213002/) Reason for revert: Breaks printing. BUG=434079 Original issue's description: > Remove calls to deprecated SkPDFDevice and SkPDFDocuemnt. > > In the PdfMetafileSkia class, Instead of storing a > SkPDFDocument, store a vector of pages as > SkPictures. This allows access to individual at any > time. When FinishDocument() is called, use the > SkDocument API to print all pages to PDF. > > BUG=278148 > > Committed: https://crrev.com/816b7105b078f7300f825cd81f379e312efdb821 > Cr-Commit-Position: refs/heads/master@{#304379} TBR=robertphillips@google.com,reed@google.com,halcanary@google.com BUG=278148 Committed: https://crrev.com/d054bfdd5eb4a364d1aa7dbf139018d3b9b885b3 Cr-Commit-Position: refs/heads/master@{#304536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -153 lines) Patch
M printing/pdf_metafile_skia.cc View 7 chunks +88 lines, -153 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Vitaly Buka (NO REVIEWS)
Created Revert of Remove calls to deprecated SkPDFDevice and SkPDFDocuemnt.
6 years, 1 month ago (2014-11-17 23:41:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/731143004/1
6 years, 1 month ago (2014-11-17 23:42:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-18 01:26:06 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 01:26:54 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d054bfdd5eb4a364d1aa7dbf139018d3b9b885b3
Cr-Commit-Position: refs/heads/master@{#304536}

Powered by Google App Engine
This is Rietveld 408576698