ui/android/DEPS - Issue 731133002: Upstream ResourceManager

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/android/DEPS

Issue 731133002: Upstream ResourceManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename namespace Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+cc",
	no sievers 2014/12/02 00:25:06 Can you add "-cc/blink"? Can you add "-cc/blink"? no sievers 2014/12/02 00:26:02 Actually, even better, only allow cc/resources spe Actually, even better, only allow cc/resources specifically. Jaekyun Seok (inactive) 2014/12/02 03:13:12 Done. Show quoted text On 2014/12/02 00:25:06, sievers wrote: > Can you add "-cc/blink"? Done.
	3 "+content/public/browser/android/ui_resource_client_android.h",

	4 "+content/public/browser/android/ui_resource_provider.h",
	no sievers 2014/12/02 00:25:06 As a follow-up, can we eliminate these base class As a follow-up, can we eliminate these base class interfaces (or move them to ui/), so we don't have to depend on content/ here? Jaekyun Seok (inactive) 2014/12/02 03:13:12 I will do that in a separate CL as a follow-up. Show quoted text On 2014/12/02 00:25:06, sievers wrote: > As a follow-up, can we eliminate these base class interfaces (or move them to > ui/), so we don't have to depend on content/ here? I will do that in a separate CL as a follow-up.
	5 "+jni",

	6 "+skia/ext",

	7 "+third_party/skia",

	8 "+ui/gfx",

	9 ]

OLD	NEW