Generate docgen output along with api_docs as part of the build

dart.gyp

 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'most',
       'type': 'none',
       'dependencies': [
@@ skipping 63 matching lines @@
             '--sdk_output_dir', '<(PRODUCT_DIR)/dart-sdk',
             '--snapshot_location', '<(SHARED_INTERMEDIATE_DIR)/'
           ],
           'message': 'Creating SDK.',
         },
       ],
     },
     {
       # Upload the SDK. This target is separate from create_sdk as the
       # editor needs to build the SDK without uploading it.
       'target_name': 'upload_sdk',

[kustermann, 2013/11/19 16:40:37]

I'm not familiar with this target. AFAIK this is not needed by our editor bots.
It seems to be archiving to 'gs://dart-dump-render-tree'.

Who uses this target?
Can we remove it [together with the tools/upload_sdk.py script]?

[Alan Knight, 2013/11/19 19:14:47]

Ah. I was naively assuming that a target by that name was doing the uploads that
I wanted, which appears not to be the case. I don't know if we can remove it or
not, or even who to ask.

It seems like the thing I actually want is in the editor's build.py script,
which explicitly calls api_docs.

I also came across an explicit build of api_docs in the pub bots, which Bob says
can be removed, so I did that.

       'type': 'none',
       'dependencies': [
         'create_sdk',
+        'api_docs',
+      ],
+      'inputs': [
+        '<(PRODUCT_DIR)/dart-sdk/README',
       ],
       'actions': [
         {
           'action_name': 'upload_sdk_py',
           'inputs': [
             '<(PRODUCT_DIR)/dart-sdk/README',
+            '<(PRODUCT_DIR)/api_docs/docgen/index.json',

[kustermann, 2013/11/19 16:40:37]

That seems to be unnecessary since the upload_sdk.py script doesn't actually use
'<PRODUCT_DIR)/api_docs', right?

[Alan Knight, 2013/11/19 19:14:47]

Yes. Reverted.

             'tools/upload_sdk.py',
           ],
           'outputs': [
             '<(PRODUCT_DIR)/dart-sdk/upload.stamp',
           ],
           'action': [
             'python',
             'tools/upload_sdk.py',
             '<(PRODUCT_DIR)/dart-sdk'
           ],
@@ skipping 44 matching lines @@
       'type': 'none',
       'dependencies': [
         'create_sdk',
         'packages',
       ],
     },
     {
       'target_name': 'api_docs',
       'type': 'none',
       'dependencies': [
+        # TODO(alanknight) : Once we're fully switched over to the new
+        # viewer remove the old api_docs gyp file.
         'utils/apidoc/apidoc.gyp:api_docs',
+        'utils/apidoc/docgen.gyp:docgen',
       ],
     },
     {
       'target_name': 'editor',
       'type': 'none',
       'dependencies': [
         'editor/build/generated/editor_deps.gyp:editor_deps',
 
         # This dependency on create_sdk does not mean that the Editor
         # is rebuilt if the SDK is. It only means that when you build
@@ skipping 42 matching lines @@
     },
     {
       'target_name': 'packages',
       'type': 'none',
       'dependencies': [
         'pkg/pkg.gyp:pkg_packages',
       ],
     },
   ],
 }