Issue 731093002: DevTools: Use View.registerRequiredCSS() in View-based web components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 731093002: DevTools: Use View.registerRequiredCSS() in View-based web components (Closed)

Created:
6 years, 1 month ago by apavlov

Modified:
6 years, 1 month ago

Reviewers:
vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Use View.registerRequiredCSS() in View-based web components R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185448

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -4 lines)			Patch
M	Source/devtools/front_end/elements/ElementsBreadcrumbs.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/elements/Spectrum.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/ui/FlameChart.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/ui/View.js	View	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/731093002/1

6 years, 1 month ago (2014-11-17 14:22:49 UTC) #6

commit-bot: I haz the power

6 years, 1 month ago (2014-11-17 15:53:36 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 185448

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages