Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: extensions/common/manifest_constants.cc

Issue 730983002: Remove dead script_badge code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mm Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/manifest_constants.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/manifest_constants.cc
diff --git a/extensions/common/manifest_constants.cc b/extensions/common/manifest_constants.cc
index a7c287a46f98026e45101c823811d5d5a0eb8373..0afc2751b1a2527e2f2757cd550313532c80c37a 100644
--- a/extensions/common/manifest_constants.cc
+++ b/extensions/common/manifest_constants.cc
@@ -126,7 +126,6 @@ const char kRequirements[] = "requirements";
const char kRunAt[] = "run_at";
const char kSandboxedPages[] = "sandbox.pages";
const char kSandboxedPagesCSP[] = "sandbox.content_security_policy";
-const char kScriptBadge[] = "script_badge";
const char kSettingsOverride[] = "chrome_settings_overrides";
const char kSettingsOverrideAlternateUrls[] =
"chrome_settings_overrides.search_provider.alternate_urls";
@@ -224,7 +223,6 @@ const char kRunAtDocumentIdle[] = "document_idle";
const char kPageActionCommandEvent[] = "_execute_page_action";
const char kPageActionTypeTab[] = "tab";
const char kPageActionTypePermanent[] = "permanent";
-const char kScriptBadgeCommandEvent[] = "_execute_script_badge";
const char kLaunchContainerPanel[] = "panel";
const char kLaunchContainerTab[] = "tab";
const char kLaunchContainerWindow[] = "window";
@@ -546,8 +544,6 @@ const char kInvalidSandboxedPage[] =
"Invalid value for 'sandbox.pages[*]'.";
const char kInvalidSandboxedPagesCSP[] =
"Invalid value for 'sandbox.content_security_policy'.";
-const char kInvalidScriptBadge[] =
- "Invalid value for 'script_badge'.";
const char kInvalidSearchEngineMissingKeys[] =
"Missing mandatory parameters for "
"'chrome_settings_overrides.search_provider'.";
@@ -688,14 +684,6 @@ const char kPermissionUnknownOrMalformed[] =
"Permission '*' is unknown or URL pattern is malformed.";
const char kReservedMessageFound[] =
"Reserved key * found in message catalog.";
-const char kScriptBadgeRequiresFlag[] =
- "The script_badge manifest key is turned off by default. "
- "You can enable it with the --enable-script-badges command-line flag.";
-const char kScriptBadgeIconIgnored[] =
- "default_icon specified in script_badge manifest section will not be used.";
-const char kScriptBadgeTitleIgnored[] =
- "default_title specified in script_badge manifest section will not be "
- "used.";
const char kUnrecognizedManifestKey[] = "Unrecognized manifest key '*'.";
const char kUnrecognizedManifestProperty[] =
"Unrecognized property '*' of manifest key '*'.";
« no previous file with comments | « extensions/common/manifest_constants.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698