Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 730983002: Remove dead script_badge code. (Closed)

Created:
6 years, 1 month ago by robwu
Modified:
6 years ago
CC:
chromium-reviews, extensions-reviews_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, klundberg+watch_chromium.org, jbudorick+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove dead script_badge code. BUG=302083 R=thakis@chromium.org R=kalman@chromium.org Committed: https://crrev.com/395281f6ca0fafd8f5cc9ee96461beed4351671d Cr-Commit-Position: refs/heads/master@{#308286}

Patch Set 1 #

Patch Set 2 : Delete more dead code #

Patch Set 3 : Bye gyp #

Patch Set 4 : rebase #

Patch Set 5 : mm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -302 lines) Patch
M build/android/pylib/gtest/filter/unit_tests_disabled View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_view_host_factory.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/resources/extensions/extension_info.css View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/resources/extensions/extension_info.html View 1 2 3 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/resources/extensions/extension_info.js View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/_manifest_features.json View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/common/extensions/api/script_badge.json View 1 chunk +0 lines, -89 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/known_broken_links.json View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/extensions_api_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/url_constants.h View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/url_constants.cc View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/test/data/extensions/api_test/keybinding/script_badge/background.js View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/extensions/api_test/keybinding/script_badge/manifest.json View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/test/data/extensions/api_test/keybinding/script_badge/popup.html View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/extensions/api_test/keybinding/script_badge/popup.js View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/extensions/api_test/keybinding/script_badge/show.html View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/extensions/api_test/keybinding/script_badge/show.js View 1 chunk +0 lines, -9 lines 0 comments Download
M extensions/common/manifest_constants.h View 1 2 3 4 chunks +0 lines, -6 lines 0 comments Download
M extensions/common/manifest_constants.cc View 1 2 3 4 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
robwu
6 years, 1 month ago (2014-11-16 22:49:56 UTC) #1
Nico
yoz, looks like you added this 2.5 years ago, can you check if this makes ...
6 years, 1 month ago (2014-11-17 18:43:54 UTC) #4
not at google - send to devlin
I think Jeffrey is probably the most familiar with all of this, though whoever feels ...
6 years, 1 month ago (2014-11-17 19:10:54 UTC) #6
Yoyo Zhou
LGTM (I think I added the info_ui, actually, and I'm pretty sure it's not used ...
6 years, 1 month ago (2014-11-18 19:46:33 UTC) #7
robwu
Could anyoneone else LG this CL? Meanwhile other CLs are duplicating the work from this ...
6 years ago (2014-12-13 12:47:36 UTC) #8
Nico
On 2014/12/13 12:47:36, robwu wrote: > Could anyoneone else LG this CL? > Meanwhile other ...
6 years ago (2014-12-13 17:43:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730983002/80001
6 years ago (2014-12-13 17:54:08 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/14592)
6 years ago (2014-12-13 18:43:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730983002/100001
6 years ago (2014-12-13 18:52:27 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:100001)
6 years ago (2014-12-13 20:31:59 UTC) #16
commit-bot: I haz the power
6 years ago (2014-12-13 20:32:52 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/395281f6ca0fafd8f5cc9ee96461beed4351671d
Cr-Commit-Position: refs/heads/master@{#308286}

Powered by Google App Engine
This is Rietveld 408576698