Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 73087: Make TextFields reroute mouse wheel messages (Closed)

Created:
11 years, 8 months ago by jcampan
Modified:
9 years, 7 months ago
Reviewers:
amit
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

The text-fields were not rerouting mouse-wheel messages, causing the window under the mouse not to scroll when a text-field (such as the find-box) was focused. BUG=9647 TEST=Navigate to a page long enough to have vertical scroll-bars (ex: http://slashdot.org). CTRL-F to open the find in page box. While the mouse is over the page (but the find in bar text-field has focus) use the mouse scroll-wheel). The page should scroll. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13794

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -0 lines) Patch
M chrome/views/controls/text_field.cc View 4 chunks +12 lines, -0 lines 0 comments Download
M chrome/views/view_unittest.cc View 2 chunks +118 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
jcampan
11 years, 8 months ago (2009-04-15 17:36:32 UTC) #1
amit
lgtm. Given the frequency of regressions in this area, it would be nice to have ...
11 years, 8 months ago (2009-04-15 17:50:57 UTC) #2
jcampan
> Given the frequency of regressions in this area, it would be nice to >have ...
11 years, 8 months ago (2009-04-15 19:32:41 UTC) #3
amit
11 years, 8 months ago (2009-04-15 20:52:23 UTC) #4
nice, lgtm.

http://codereview.chromium.org/73087/diff/1002/1004
File chrome/views/view_unittest.cc (right):

http://codereview.chromium.org/73087/diff/1002/1004#newcode789
Line 789: window2->Show();
Does showing automatically activate this window? This window needs to active
(i.e. receiving user input) in order to test the intended redirection. Or more
accurately, we need to make sure that window1 is not active :)

Powered by Google App Engine
This is Rietveld 408576698