MacViews: Implement event monitoring for a specific window

ui/views/event_monitor_mac.mm

Index: ui/views/event_monitor_mac.mm
diff --git a/ui/views/event_monitor_mac.mm b/ui/views/event_monitor_mac.mm
index a04f292550447e5d92b6a88c3205afb1f78d11ef..a5818e87de4d9b15c7c2c1e5d56de14072a969cf 100644
--- a/ui/views/event_monitor_mac.mm
+++ b/ui/views/event_monitor_mac.mm
@@ -13,7 +13,13 @@ namespace views {
 
 // static
 EventMonitor* EventMonitor::Create(ui::EventHandler* event_handler) {
-  return new EventMonitorMac(event_handler);
+  return new EventMonitorMac(event_handler, nullptr);
+}
+
+// static
+EventMonitor* EventMonitor::Create(ui::EventHandler* event_handler,
+                                   gfx::NativeWindow target_window) {
+  return new EventMonitorMac(event_handler, target_window);
 }
 
 // static
@@ -25,12 +31,15 @@ gfx::Point EventMonitor::GetLastMouseLocation() {
   return gfx::Point(mouseLocation.x, mouseLocation.y);

[tapted, 2014/11/20 22:39:02]

also orthogonal, but we probably should move this snippet to
ui/gfx/mac/coordinate_conversion.h at some point

[Andre, 2014/11/21 00:28:28]

Yeah, we should add ScreenPointFromNSPoint there.

 }
 
-EventMonitorMac::EventMonitorMac(ui::EventHandler* event_handler) {
+EventMonitorMac::EventMonitorMac(ui::EventHandler* event_handler,
+                                 gfx::NativeWindow target_window) {
   DCHECK(event_handler);
   monitor_ = [NSEvent addLocalMonitorForEventsMatchingMask:NSAnyEventMask
       handler:^NSEvent*(NSEvent* event){
-                  scoped_ptr<ui::Event> ui_event = ui::EventFromNative(event);
-                  event_handler->OnEvent(ui_event.get());
+                  if (!target_window || [event window] == target_window) {

[tapted, 2014/11/20 22:39:02]

Can the EventMonitorMac outlive this NSWindow?

(Maybe this is something to plonk on BridgedNativeWidget, which is kinda like
our aura::Window)

[Andre, 2014/11/21 00:28:28]

There is that risk, same with EventMonitorAura as well.
We can use something like NativeWindowTracker, I suppose.
Which part are you thinking to plonk on BridgedNativeWidget?
I see you are adding GetBridgeForNativeWindow, but how will that help is the
window is already destroyed?

[tapted, 2014/11/21 00:57:34]

WidgetObserver might be nicer, in which case these Create functions could take a
Widget* instead.

GetBridgeForNativeWindow would allow you to call a function like
BridgedNativeWidget::AddPreTargetHandler


If you make it clear on the added Create method (i.e. comment) that the
EventMonitor must be destroyed before |target_window|, it might be fine as-is.
No point over-engineering if the callers are already doing this (and getting a
Widget* from webcontents might be tricky)

[Andre, 2014/12/10 00:18:13]

Done.
Added the comment.

+                    scoped_ptr<ui::Event> ui_event = ui::EventFromNative(event);
+                    event_handler->OnEvent(ui_event.get());
+                  }
                   return event;
               }];
 }