native_client_sdk/src/libraries/ppapi_simple/library.dsc - Issue 73083005: [NaCl SDK] Enable linux host build for nacl_io and nacl_io_tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: native_client_sdk/src/libraries/ppapi_simple/library.dsc

Issue 73083005: [NaCl SDK] Enable linux host build for nacl_io and nacl_io_tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« native_client_sdk/src/libraries/nacl_io/ossignal.h ('K') | « native_client_sdk/src/libraries/nacl_io/ostermios.h ('k') | native_client_sdk/src/tests/nacl_io_test/example.dsc » ('j') | native_client_sdk/src/tests/nacl_io_test/kernel_wrap_test.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 'TOOLS': ['newlib', 'glibc', 'pnacl'],	2 'TOOLS': ['newlib', 'glibc', 'pnacl', 'linux'],
	binji 2013/11/15 17:26:23 not sure this is a good idea -- the first call to not sure this is a good idea -- the first call to mount will call the real mount function, right? Sam Clegg 2013/11/15 18:13:34 No because we intercept mount directly in syscalls Show quoted text On 2013/11/15 17:26:23, binji wrote: > not sure this is a good idea -- the first call to mount will call the real mount > function, right? No because we intercept mount directly in syscalls/mount.c. It only the function like fopen/fclose/etc where we intercept at the low level that we will get failures. For sure nacl_io will not work as expected under linux but enabling the linux build enables us to do all this great testing. binji 2013/11/15 18:21:18 Agreed, I'm just not sure we want to turn it out f Show quoted text On 2013/11/15 18:13:34, Sam Clegg wrote: > On 2013/11/15 17:26:23, binji wrote: > > not sure this is a good idea -- the first call to mount will call the real > mount > > function, right? > > No because we intercept mount directly in syscalls/mount.c. > > It only the function like fopen/fclose/etc where we intercept at the low > level that we will get failures. > > For sure nacl_io will not work as expected under linux but enabling the > linux build enables us to do all this great testing. Agreed, I'm just not sure we want to turn it out for ppapi_simple. Or is it required because the tests use it?
3 'TARGETS': [	3 'TARGETS': [

4 {	4 {

5 'NAME' : 'ppapi_simple',	5 'NAME' : 'ppapi_simple',

6 'TYPE' : 'lib',	6 'TYPE' : 'lib',

7 'SOURCES' : [	7 'SOURCES' : [

8 "ps.cc",	8 "ps.cc",

9 "ps_context_2d.cc",	9 "ps_context_2d.cc",

10 "ps_event.cc",	10 "ps_event.cc",

11 "ps_instance.cc",	11 "ps_instance.cc",

12 "ps_interface.cc",	12 "ps_interface.cc",

(...skipping 10 matching lines...) Expand all Loading...
23 "ps_instance.h",	23 "ps_instance.h",

24 "ps_interface.h",	24 "ps_interface.h",

25 "ps_main.h",	25 "ps_main.h",

26 ],	26 ],

27 'DEST': 'include/ppapi_simple',	27 'DEST': 'include/ppapi_simple',

28 },	28 },

29 ],	29 ],

30 'DEST': 'src',	30 'DEST': 'src',

31 'NAME': 'ppapi_simple',	31 'NAME': 'ppapi_simple',

32 }	32 }

OLD	NEW