Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 730813002: Remove gyp for mojo_surfaces targets (Closed)

Created:
6 years, 1 month ago by jamesr
Modified:
6 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove gyp for mojo_surfaces targets The only targets using these libraries are mojo targets which are GN-only, so we don't need to keep gyp rules around. Committed: https://crrev.com/25d1f9299f32cf322a5927da7659ae6434ac6157 Cr-Commit-Position: refs/heads/master@{#304353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -88 lines) Patch
M mojo/mojo.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D mojo/mojo_surface_converters.gyp View 1 chunk +0 lines, -82 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jamesr
6 years, 1 month ago (2014-11-15 02:18:32 UTC) #2
sky
LGTM
6 years, 1 month ago (2014-11-15 02:33:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730813002/1
6 years, 1 month ago (2014-11-15 02:57:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-15 04:21:49 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-15 04:22:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25d1f9299f32cf322a5927da7659ae6434ac6157
Cr-Commit-Position: refs/heads/master@{#304353}

Powered by Google App Engine
This is Rietveld 408576698