Fixing a crash which could occur when a string containing multibyte characters is p...

Fixing a crash which could occur when a string containing multibyte characters is passed to AutocompleteEditViewGtk::EmphasizeURLComponents().

The AutocompleteInput::Parse works in a wstring, so the parts indices are also for a wstring.  Convert these to utf8 byte indices.

BUG=10539

[Dean McNamee, 2009-04-15 10:15:03]

On 2009/04/15 10:08:42, yusukes wrote:
> 

I think this isn't actually completely correct, it's sort of a regression
regression.  Parts used to be utf8, so these indices where in utf8.  Recently
there was a change so that now the indices are wstring (utf16 on windows utf32
on Linux?).  They are not character indices, they are just byte indices and
there isn't a surrogate pair?

I think for Linux AutocompleteInput::Parse should work in UTF8, or we should use
parts.host.end / to pull out the substring, convert the substring to utf8, and
then calculate it that way...

[Dean McNamee, 2009-04-15 10:17:33]

http://codereview.chromium.org/73078/diff/1/2
File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (left):

http://codereview.chromium.org/73078/diff/1/2#oldcode520
Line 520: parts.host.begin);
Make this should be more like

std::wstring text = GetText();
WideToUTF8(text.substr(0, parts.host.begin())).size();

Basically we need to convert the parts from wstring to utf8.

[Dean McNamee, 2009-04-15 10:58:13]

http://codereview.chromium.org/73078/diff/5/1003
File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (right):

http://codereview.chromium.org/73078/diff/5/1003#newcode512
Line 512: const std::wstring& text = GetText();
GetText() returns a std::wstring (a copy), I don't see the point of storing a
reference to that (is it even correct?).  Also, I don't usually use 'const' on
local variables unless it is required.

http://codereview.chromium.org/73078/diff/5/1003#newcode541
Line 541: parts.host.end()));
you change scheme to host here.  it should be scheme.

[Yusuke (unused), 2009-04-15 11:13:50]

Thanks for the review!
Fixed all.

http://codereview.chromium.org/73078/diff/5/1003
File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (right):

http://codereview.chromium.org/73078/diff/5/1003#newcode512
Line 512: const std::wstring& text = GetText();
On 2009/04/15 10:58:13, Dean McNamee wrote:
> GetText() returns a std::wstring (a copy), I don't see the point of storing a
> reference to that (is it even correct?).  Also, I don't usually use 'const' on
> local variables unless it is required.

Sure. Removed the const and &.

http://codereview.chromium.org/73078/diff/5/1003#newcode541
Line 541: parts.host.end()));
On 2009/04/15 10:58:13, Dean McNamee wrote:
> you change scheme to host here.  it should be scheme.

Done. Sorry for the typo..

[Dean McNamee, 2009-04-15 11:19:52]

I updated the description and will commit.

LG, thanks!

[Dean McNamee, 2009-04-15 14:17:26]

Committed in 13741, sorry, I didn't properly attribute the patch to you, since I
just reused the Rietveld description :\