Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 730693005: Generalize V4L2 HW video codec device names (Closed)

Created:
6 years ago by Pawel Osciak
Modified:
6 years ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org, jln+watch_chromium.org, wiley, bshe, dharani1, jrbarnette, ilja, Jorge Lucangeli Obes, scherkus (not reviewing), henryhsu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Generalize V4L2 HW video codec device names Switch to more generalized V4L2 video accelerator device names and update sandbox rules to reflect that. This is another attempt at crrev.com/763743002, reverted in crrev.com/767383002 with a fixup for sandbox permissions. BUG=405861, 437598 TEST=compile Committed: https://crrev.com/30a3721c82953428d445a93ebe2bf0014e27bc10 Cr-Commit-Position: refs/heads/master@{#306642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -307 lines) Patch
D content/common/gpu/media/exynos_v4l2_video_device.h View 1 chunk +0 lines, -58 lines 0 comments Download
D content/common/gpu/media/exynos_v4l2_video_device.cc View 1 chunk +0 lines, -211 lines 0 comments Download
A + content/common/gpu/media/generic_v4l2_video_device.h View 2 chunks +9 lines, -9 lines 0 comments Download
A + content/common/gpu/media/generic_v4l2_video_device.cc View 8 chunks +17 lines, -17 lines 0 comments Download
M content/common/gpu/media/v4l2_video_device.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M content/content_common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Pawel Osciak
scherkus@: please owners for media jorgelo@: please owners for sandbox Thanks.
6 years ago (2014-12-02 00:26:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730693005/1
6 years ago (2014-12-02 00:27:20 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-12-02 00:27:22 UTC) #6
Jorge Lucangeli Obes
Did you send it in before el-gee-tee-ems? lgtm for sandbox
6 years ago (2014-12-02 00:30:24 UTC) #7
Pawel Osciak
On 2014/12/02 00:30:24, Jorge Lucangeli Obes wrote: > Did you send it in before el-gee-tee-ems? ...
6 years ago (2014-12-02 00:31:25 UTC) #8
scherkus (not reviewing)
lgtm
6 years ago (2014-12-02 18:41:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730693005/1
6 years ago (2014-12-03 19:11:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-03 19:22:29 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/30a3721c82953428d445a93ebe2bf0014e27bc10 Cr-Commit-Position: refs/heads/master@{#306642}
6 years ago (2014-12-03 19:23:24 UTC) #13
jonross
6 years ago (2014-12-05 20:53:31 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/784553004/ by jonross@chromium.org.

The reason for reverting is: This change breaks video_ChromeHWDecodeUsed, please
see crbug.com/439175 for details..

Powered by Google App Engine
This is Rietveld 408576698