Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1689)

Issue 730623002: Rename network_prefix to prefix_length in NetworkInterface structure (Closed)

Created:
6 years, 1 month ago by guoweis_left_chromium
Modified:
6 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename network_prefix to prefix_length in NetworkInterface structure. BUG= Committed: https://crrev.com/4c60e323e1bafaed53f74419be2a6422e8bbc830 Cr-Commit-Position: refs/heads/master@{#305017}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -35 lines) Patch
M chrome/browser/local_discovery/privet_traffic_detector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/p2p_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/p2p/ipc_network_manager.cc View 1 2 chunks +4 lines, -10 lines 0 comments Download
M extensions/browser/api/socket/socket_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/system_network/system_network_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/net_util.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M net/base/net_util_unittest.cc View 10 chunks +11 lines, -11 lines 0 comments Download
M net/base/net_util_win.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (7 generated)
guoweis2
Simple name change. Please OWNER review these. jamesr@chromium.org: Please review changes in content/renderer/p2p/ipc_network_manager.cc jhawkins@chromium.org: Please ...
6 years, 1 month ago (2014-11-19 18:46:32 UTC) #4
James Hawkins
lgtm
6 years, 1 month ago (2014-11-19 19:24:29 UTC) #5
pauljensen
net/base/net_util_win.cc contains net_prefix which should also be changed to prefix_length
6 years, 1 month ago (2014-11-19 19:29:52 UTC) #6
jamesr
We have content/renderer/p2p/ owners who (presumably) have more specialized knowledge of this code. Could they ...
6 years, 1 month ago (2014-11-19 20:40:54 UTC) #7
guoweis2
juberti@, please review content/renderer/p2p/ipc_network_manager.cc
6 years, 1 month ago (2014-11-19 21:46:02 UTC) #9
guoweis2
On 2014/11/19 21:46:02, guoweis2 wrote: > juberti@, please review content/renderer/p2p/ipc_network_manager.cc pauljensen@, PTAL for files under ...
6 years, 1 month ago (2014-11-19 21:50:44 UTC) #10
guoweis2
jschuh@chromium.org: Please review changes in p2p_message.h as wfh@ is on vacation.
6 years, 1 month ago (2014-11-19 23:21:47 UTC) #13
juberti2
ipc_network_manager.cc lgtm
6 years, 1 month ago (2014-11-20 00:27:07 UTC) #14
benwells
lgtm
6 years, 1 month ago (2014-11-20 02:26:41 UTC) #15
benwells
lgtm
6 years, 1 month ago (2014-11-20 02:26:41 UTC) #16
benwells
lgtm
6 years, 1 month ago (2014-11-20 02:26:42 UTC) #17
jschuh
ipc security lgtm: member variable rename
6 years, 1 month ago (2014-11-20 13:11:41 UTC) #18
pauljensen
net/ lgtm. Thanks for doing this; the old name was very misleading, a bug waiting ...
6 years, 1 month ago (2014-11-20 14:18:50 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730623002/60001
6 years, 1 month ago (2014-11-20 14:27:14 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:60001)
6 years, 1 month ago (2014-11-20 16:01:30 UTC) #22
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 16:02:20 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c60e323e1bafaed53f74419be2a6422e8bbc830
Cr-Commit-Position: refs/heads/master@{#305017}

Powered by Google App Engine
This is Rietveld 408576698