Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: sky/specs/style.md

Issue 730603003: Specs: note one of the big problems with the current style system: that rule order isn't maintained (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/specs/style.md
diff --git a/sky/specs/style.md b/sky/specs/style.md
index 82cb679116fbe241ee12f2e17d7a781fd5aabb58..96ff3af880b54b48a75a9856dd19a42537ed005b 100644
--- a/sky/specs/style.md
+++ b/sky/specs/style.md
@@ -256,6 +256,7 @@ class StyleDeclarationList {
constructor ();
void add(StyleDeclaration styles, String? pseudoElement = null); // O(1) // in debug mode, throws if the dictionary has any properties that aren't registered
void remove(StyleDeclaration styles, String? pseudoElement = null); // O(N) in number of declarations
+ // TODO(ianh): Need to support inserting rules preserving order somehow
Array<StyleDeclaration> getDeclarations(String? pseudoElement = null); // O(N) in number of declarations
}
@@ -280,6 +281,8 @@ Each frame, at some defined point relative to requestAnimationFrame():
- If a rule starts applying to an element, sky:core calls thatElement.style.add(rule.styles, rule.pseudoElement);
- If a rule stops applying to an element, sky:core calls thatElement.style.remove(rule.styles, rule.pseudoElement);
+TODO(ianh): fix the above so that rule order is maintained
+
Cascade
-------
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698