chrome/renderer/pepper/pepper_flash_drm_renderer_host.cc - Issue 730603002: PPAPI: Refactor renderer side of browser host creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/pepper/pepper_flash_drm_renderer_host.cc

Issue 730603002: PPAPI: Refactor renderer side of browser host creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/pepper/pepper_flash_drm_renderer_host.h ('k') | content/browser/renderer_host/pepper/pepper_renderer_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/pepper/pepper_flash_drm_renderer_host.cc

diff --git a/chrome/renderer/pepper/pepper_flash_drm_renderer_host.cc b/chrome/renderer/pepper/pepper_flash_drm_renderer_host.cc

index 2e95d23dd41d8e1bc953da31be5a5cab57ae936c..1018a6e61a183ce318fcee565115e70bf1e59157 100644

--- a/chrome/renderer/pepper/pepper_flash_drm_renderer_host.cc

+++ b/chrome/renderer/pepper/pepper_flash_drm_renderer_host.cc

@@ -73,9 +73,12 @@ void PepperFlashDRMRendererHost::DidCreateFileRefHosts(

const ppapi::host::ReplyMessageContext& reply_context,

const base::FilePath& external_path,

int renderer_pending_host_id,

- const std::vector<int>& browser_pending_host_ids) {

- DCHECK_EQ(1U, browser_pending_host_ids.size());

- int browser_pending_host_id = browser_pending_host_ids[0];

+ const ppapi::proxy::CompletedBrowserResourceHosts& browser_hosts) {

+ if (browser_hosts.host_ids.empty()) {

+ NOTREACHED();

+ return;

+ }

+ int browser_pending_host_id = browser_hosts.host_ids[0];

ppapi::FileRefCreateInfo create_info =

ppapi::MakeExternalFileRefCreateInfo(external_path,