Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2717)

Unified Diff: content/renderer/pepper/renderer_ppapi_host_impl.cc

Issue 730603002: PPAPI: Refactor renderer side of browser host creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sequence_id->sequence_num Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/renderer_ppapi_host_impl.cc
diff --git a/content/renderer/pepper/renderer_ppapi_host_impl.cc b/content/renderer/pepper/renderer_ppapi_host_impl.cc
index b6e6e9e7e46d08d3789a082ddf88d87788a68da4..b48d556a4954686f2107ab927e2b1c9cb6dba8e5 100644
--- a/content/renderer/pepper/renderer_ppapi_host_impl.cc
+++ b/content/renderer/pepper/renderer_ppapi_host_impl.cc
@@ -241,19 +241,20 @@ void RendererPpapiHostImpl::SetToExternalPluginHost() {
is_external_plugin_host_ = true;
}
-void RendererPpapiHostImpl::CreateBrowserResourceHosts(
+int32_t RendererPpapiHostImpl::CreateBrowserResourceHosts(
PP_Instance instance,
const std::vector<IPC::Message>& nested_msgs,
- const base::Callback<void(const std::vector<int>&)>& callback) const {
+ const PendingResourceCallback& callback) const {
RenderFrame* render_frame = GetRenderFrameForInstance(instance);
PepperBrowserConnection* browser_connection =
PepperBrowserConnection::Get(render_frame);
if (!browser_connection) {
+ ppapi::proxy::CompletedBrowserResourceHosts empty;
base::MessageLoop::current()->PostTask(
- FROM_HERE,
- base::Bind(callback, std::vector<int>(nested_msgs.size(), 0)));
+ FROM_HERE, base::Bind(callback, empty));
+ return -1;
} else {
- browser_connection->SendBrowserCreate(
+ return browser_connection->SendBrowserCreate(
module_->GetPluginChildId(), instance, nested_msgs, callback);
}
}

Powered by Google App Engine
This is Rietveld 408576698