Issue 730563002: Revert "Merge 663413002 to M39:"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 730563002: Revert "Merge 663413002 to M39:" (Closed)

Created:
6 years, 1 month ago by no longer working on chromium

Modified:
6 years, 1 month ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, klundberg+watch_chromium.org, wjia+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2171

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "Merge 663413002 to M39:" This reverts commit 255ee24a13c30cdd0e6cd75db897f03f35bc0674. R=tommi@chromium.org Revert of Reland 597923002: Fix the way how we create webrtc::AudioProcessing in Chrome (patchset #4 id:60001 of https://codereview.chromium.org/663413002/) Reason for revert: This CL broke the configuration of AudioProcessing, we have to revert it to fix the echo issues it introduces. Original issue's description: > Reland 597923002: Fix the way how we create webrtc::AudioProcessing in Chrome. > > The original review thread is in https://codereview.chromium.org/588523002/ > > Fix the way how we create webrtc::AudioProcessing in Chrome. > > TBR=tommi@chromium.org,maruel@chromium.org > > BUG=415935 > TEST=all webrtc tests in all bots + manual test to verify the agc loggings exist. Committed: https://chromium.googlesource.com/chromium/src/+/e78feb7865c15d596a428ba892f842c653995615

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -74 lines)			Patch
M	build/android/pylib/gtest/setup.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/content_tests.gypi	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	content/content_unittests.isolate	View	2 chunks	+0 lines, -14 lines	0 comments	Download
M	content/renderer/media/media_stream_audio_processor.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	content/renderer/media/media_stream_audio_processor_options.cc	View	1 chunk	+8 lines, -3 lines	0 comments	Download
M	third_party/libjingle/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/libjingle/libjingle.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/libjingle/overrides/init_webrtc.h	View	4 chunks	+1 line, -12 lines	0 comments	Download
M	third_party/libjingle/overrides/init_webrtc.cc	View	5 chunks	+2 lines, -20 lines	0 comments	Download
M	third_party/libjingle/overrides/initialize_module.cc	View	3 chunks	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

no longer working on chromium

6 years, 1 month ago (2014-11-14 15:54:33 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as e78feb7.

Expand Messages | Collapse Messages