LayoutTests/http/tests/serviceworker/resources/postmessage-cross-process-helper.html - Issue 730543005: Add a test for cross process service worker messaging.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/serviceworker/resources/postmessage-cross-process-helper.html

Issue 730543005: Add a test for cross process service worker messaging. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address most comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/http/tests/serviceworker/postmessage-cross-process.html ('K') | « LayoutTests/http/tests/serviceworker/postmessage-cross-process.html ('k') | LayoutTests/http/tests/serviceworker/resources/postmessage-cross-process-worker.js » ('j') | LayoutTests/http/tests/serviceworker/resources/postmessage-cross-process-worker.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="test-helpers.js"></script>

	3 <script>

	4 if (window.testRunner) {

	5 // waitUntilDone here is necesary to make sure content_shell doesn't exist as
	falken 2014/11/20 02:29:13 some typos here: "necesary"->"necessary", "exist"- some typos here: "necesary"->"necessary", "exist"->"exit" Marijn Kruisselbrink 2014/11/20 20:41:13 Done. Show quoted text On 2014/11/20 02:29:13, falken wrote: > some typos here: "necesary"->"necessary", "exist"->"exit" Done.
	6 // soon as this file is loaded.

	7 testRunner.waitUntilDone();

	8 }

	9

	10 var worker;

	11

	12 navigator.serviceWorker.getRegistration('simple.html')

	13 .then(function(registration) {

	14 return get_newest_worker(registration);
	falken 2014/11/20 02:29:12 Since we open this file after the worker activated Since we open this file after the worker activated, you can just use registration.active here too. Marijn Kruisselbrink 2014/11/20 20:41:12 Done. Show quoted text On 2014/11/20 02:29:12, falken wrote: > Since we open this file after the worker activated, you can just use > registration.active here too. Done.
	15 })

	16 .then(function(sw) {

	17 worker = sw;

	18 var messageChannel = new MessageChannel();

	19 messageChannel.port1.onmessage = onMessage;

	20 sw.postMessage({port: messageChannel.port2}, [messageChannel.port2]);

	21 messageChannel.port1.postMessage({value: 1});

	22 messageChannel.port1.postMessage({value: 2});

	23 messageChannel.port1.postMessage({done: true});

	24 });

	25

	26 var result = [];

	27

	28 function onMessage(e) {
	falken 2014/11/20 02:29:13 on_message on_message Marijn Kruisselbrink 2014/11/20 20:41:13 Done. Show quoted text On 2014/11/20 02:29:13, falken wrote: > on_message Done.
	29 var message = e.data;

	30 if (message === 'quit') {

	31 worker.postMessage({done: result});

	32 } else {

	33 result.push(message);

	34 }

	35 };
	falken 2014/11/20 02:29:12 no semi-colon needed here no semi-colon needed here Marijn Kruisselbrink 2014/11/20 20:41:13 Done. Show quoted text On 2014/11/20 02:29:12, falken wrote: > no semi-colon needed here Done.
	36 </script>

OLD	NEW