LayoutTests/http/tests/serviceworker/postmessage-cross-process.html - Issue 730543005: Add a test for cross process service worker messaging.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/serviceworker/postmessage-cross-process.html

Issue 730543005: Add a test for cross process service worker messaging. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address most comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/http/tests/serviceworker/resources/postmessage-cross-process-helper.html » ('j') | LayoutTests/http/tests/serviceworker/resources/postmessage-cross-process-helper.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Service Worker: postMessage across processes</title>

	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="resources/test-helpers.js"></script>

	6 <script>

	7 if (window.testRunner) {

	8 testRunner.setCanOpenWindows();

	9 }

	10

	11 function openUrlInNewWindow(url) {
	falken 2014/11/20 02:29:12 In Service Worker test style <http://www.chromium. In Service Worker test style <http://www.chromium.org/blink/serviceworker/testing> function names are snake_case. Marijn Kruisselbrink 2014/11/20 20:41:12 Done. Show quoted text On 2014/11/20 02:29:12, falken wrote: > In Service Worker test style > <http://www.chromium.org/blink/serviceworker/testing> > function names are snake_case. Done. Marijn Kruisselbrink 2014/11/20 20:41:12 Done. Show quoted text On 2014/11/20 02:29:12, falken wrote: > In Service Worker test style > <http://www.chromium.org/blink/serviceworker/testing> > function names are snake_case. Done.
	12 var a = document.createElement('a');

	13 a.href = url;

	14 // rel=noreferrer causes chrome to open the link in a new renderer process.

	15 a.setAttribute('rel', 'noreferrer');

	16 a.target = '_blank';

	17 a.click();

	18 }

	19

	20 async_test(function(t) {

	21 var scope = 'resources/simple.html';

	22 var registration;

	23 service_worker_unregister_and_register(

	24 t, 'resources/postmessage-cross-process-worker.js', scope)

	25 .then(function(r) {

	26 registration = r;

	27 return wait_for_activated(t, registration);

	28 })

	29 .then(function() {

	30 return get_newest_worker(registration);
	falken 2014/11/20 02:29:12 You can just use registration.active directly. No You can just use registration.active directly. No need for this helper (this helper is unnecessarily promisified anyway... see crbug.com/425900) Marijn Kruisselbrink 2014/11/20 20:41:12 Done. Show quoted text On 2014/11/20 02:29:12, falken wrote: > You can just use registration.active directly. No need for this helper (this > helper is unnecessarily promisified anyway... see crbug.com/425900) Done.
	31 })

	32 .then(function(worker) {

	33 openUrlInNewWindow('resources/postmessage-cross-process-helper.html');

	34 var messageChannel = new MessageChannel();

	35 messageChannel.port1.onmessage = t.step_func(onMessage);

	36 worker.postMessage({resultport: messageChannel.port2},

	37 [messageChannel.port2]);

	38 })

	39 .catch(unreached_rejection(t));

	40

	41 var expected = [

	42 'Acking value: 1',

	43 'Acking value: 2',

	44 ];

	45

	46 function onMessage(e) {

	47 var result = e.data;

	48 assert_array_equals(result, expected,

	49 'Worker should ack values posted by new window in order.');

	50 t.done();

	51 }

	52 }, 'postMessage MessagePorts from client to SW in a different process');

	53 </script>

OLD	NEW