Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: tests/lib/mirrors/intercepted_object_test.dart

Issue 730543002: Remove use of IterableMixinWorkaround from _List, _ImmutableList and _GrowableList. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: addressed comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/collection/list.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/intercepted_object_test.dart
===================================================================
--- tests/lib/mirrors/intercepted_object_test.dart (revision 41737)
+++ tests/lib/mirrors/intercepted_object_test.dart (working copy)
@@ -16,6 +16,11 @@
ClassMirror cls = reflect(object).type;
checkClassMirrorMethods(cls);
+ // The VM implements List via a mixin, so check for that.
+ if (cls.superinterfaces.isEmpty && object is List) {
+ cls = cls.superclass.superclass.mixin;
Ivan Posva 2014/11/18 07:24:18 This is similar hard coding as was removed in othe
Florian Schneider 2014/11/18 10:20:19 Yes, but it is just a test which can easily be ada
+ }
+
List<ClassMirror> superinterfaces = cls.superinterfaces;
String symName = 's($name)';
for (ClassMirror superinterface in superinterfaces) {
« no previous file with comments | « sdk/lib/collection/list.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698