Issue 73053002: Hash whitelist IDs for consistency and best practices

Issue 73053002: Hash whitelist IDs for consistency and best practices (Closed)

Created:
7 years, 1 month ago by miket_OOO

Modified:
7 years, 1 month ago

Reviewers:
asargent_no_longer_on_chrome, not at google - send to devlin

CC:
not at google - send to devlin

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Hash whitelist IDs for consistency and to demonstrate best practices. BUG=178780 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235849

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -88 lines)			Patch
	M	chrome/common/extensions/api/_permission_features.json	View	1 2	29 chunks	+97 lines, -88 lines	0 comments	Download

Total messages: 9 (0 generated)

asargent_no_longer_on_chrome

Per offline discussion, remember to include link to internal page. lgtm

7 years, 1 month ago (2013-11-14 21:18:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miket@chromium.org/73053002/750001

7 years, 1 month ago (2013-11-18 20:55:54 UTC) #3

not at google - send to devlin

Btw what about the whitelists from the other features files/

7 years, 1 month ago (2013-11-18 23:22:17 UTC) #4

commit-bot: I haz the power

List of reviewers changed. kalman@chromium.org did a drive-by without LGTM'ing!

7 years, 1 month ago (2013-11-18 23:30:53 UTC) #5

miket_OOO

On 2013/11/18 23:22:17, kalman wrote: > Btw what about the whitelists from the other features ...

7 years, 1 month ago (2013-11-18 23:33:55 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miket@chromium.org/73053002/750001

7 years, 1 month ago (2013-11-18 23:37:03 UTC) #7

Message was sent while issue was closed.

Change committed as 235849