Issue 730463002: Revert of DevTools: Split NetworkPanel.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 730463002: Revert of DevTools: Split NetworkPanel.js (Closed)

Created:
6 years, 1 month ago by pfeldman

Modified:
6 years, 1 month ago

Reviewers:
vsevik, eustas, apavlov

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of DevTools: Split NetworkPanel.js (patchset #5 id:80001 of https://codereview.chromium.org/722683003/) Reason for revert: Don't overwrite files. Original issue's description: > DevTools: Split NetworkPanel.js > > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185306 TBR=vsevik@chromium.org,apavlov@chromium.org,eustas@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185358

Patch Set 1 #

Created: 6 years, 1 month ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+2456 lines, -2518 lines)			Patch
M	LayoutTests/inspector/network/network-filter-updated-requests.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/devtools.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	Source/devtools/front_end/network/NetworkDataGridNode.js	View	1 chunk	+0 lines, -610 lines	0 comments	Download
D	Source/devtools/front_end/network/NetworkLogView.js	View	1 chunk	+0 lines, -1902 lines	0 comments	Download
M	Source/devtools/front_end/network/NetworkPanel.js	View	5 chunks	+2455 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/network/module.json	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730463002/1

6 years, 1 month ago (2014-11-14 08:54:35 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-11-14 08:55:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 185358

Expand Messages | Collapse Messages