Issue 730443002: Oilpan: We shouldn't calculate allocationSizeFromSize twice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 730443002: Oilpan: We shouldn't calculate allocationSizeFromSize twice (Closed)

Created:
6 years, 1 month ago by haraken

Modified:
6 years, 1 month ago

Reviewers:
oilpan-reviews, sof

CC:
blink-reviews, haraken, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: We shouldn't calculate allocationSizeFromSize twice Currently we calculate allocationSizeFromSize twice in Heap::allocate() and Heap::outOfLineAllocate(). This CL removes the redundancy. BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185355

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	Source/platform/heap/Heap.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	Source/platform/heap/Heap.cpp	View		2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730443002/1

6 years, 1 month ago (2014-11-14 06:30:57 UTC) #6

commit-bot: I haz the power

6 years, 1 month ago (2014-11-14 08:28:21 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 185355

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages