Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 730383002: Fix IC handler cache clearing for JSBuiltinsObject (Closed)

Created:
6 years, 1 month ago by Jakob Kummerow
Modified:
6 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev, Weiliang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Fix IC handler cache clearing for JSBuiltinsObject The clearing mechanism relies on comparing the cached handler with the installed handler. If we try to preserve monomorphism by pretending that the IC was in uninitialized state, then it will go premonomorphic first, which means on the next miss there's no installed handler available to compare against. Instead, pretend it was premonomorphic, so the comparison will happen right away, will fail as it should, and the cached handler will be cleared. Thanks to Weiliang for starting the investigation that led to this. R=verwaest@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/c177910d92e413adbf18c313ccfbc30cad3eb1f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ic/ic.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Jakob Kummerow
Toon: PTAL. Weiliang: FYI.
6 years, 1 month ago (2014-11-18 13:32:20 UTC) #2
Toon Verwaest
lgtm
6 years, 1 month ago (2014-11-18 13:35:04 UTC) #3
Jakob Kummerow
6 years, 1 month ago (2014-11-18 13:35:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c177910d92e413adbf18c313ccfbc30cad3eb1f3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698