Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Issue 730353002: Add a media scanner convenience class. (Closed)

Created:
6 years, 1 month ago by Ben Kwa
Modified:
6 years, 1 month ago
Reviewers:
fukino
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, dbeam+watch-closure_chromium.org, mtomasz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a media scanner convenience class. Create a new class that takes in a list of directories, recursively scans them for image and video files, and returns the resulting list. BUG=420680 TEST=browser_test: FileManagerJsTest.MediaScannerTest Committed: https://crrev.com/340e607f73159216a2e7359c0a71170b9d4668f9 Cr-Commit-Position: refs/heads/master@{#304582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+368 lines, -4 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_jstest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A + chrome/test/data/file_manager/unit_tests/media_scanner_unittest.html View 1 chunk +8 lines, -3 lines 0 comments Download
A chrome/test/data/file_manager/unit_tests/media_scanner_unittest.js View 1 chunk +285 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/background/js/compiled_resources.gyp View 2 chunks +3 lines, -1 line 0 comments Download
A ui/file_manager/file_manager/background/js/media_scanner.js View 1 chunk +65 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ben Kwa
6 years, 1 month ago (2014-11-18 05:52:01 UTC) #2
fukino
lgtm!
6 years, 1 month ago (2014-11-18 06:56:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730353002/1
6 years, 1 month ago (2014-11-18 08:46:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-18 10:25:29 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/340e607f73159216a2e7359c0a71170b9d4668f9 Cr-Commit-Position: refs/heads/master@{#304582}
6 years, 1 month ago (2014-11-18 10:26:13 UTC) #7
Michael Achenbach
6 years, 1 month ago (2014-11-18 12:26:20 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/735013002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Fails on cros and ozone:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2....

Powered by Google App Engine
This is Rietveld 408576698