Add keyboard navigation for start page tiles in experimental app list.

Add keyboard navigation for start page tiles in experimental app list.

This CL adds keyboard navigation to the tiles on the experimental app list's
start page.

BUG=438568
Committed: https://crrev.com/fe62ca8a995c9ded8d985511b403a5c7ff79c8d8
Cr-Commit-Position: refs/heads/master@{#307873}

[calamity, 2014-12-09 07:08:08]

calamity@chromium.org changed reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2014-12-09 08:02:01]

https://codereview.chromium.org/730343008/diff/1/ui/app_list/views/start_page...
File ui/app_list/views/start_page_view.cc (right):

https://codereview.chromium.org/730343008/diff/1/ui/app_list/views/start_page...
ui/app_list/views/start_page_view.cc:169:
tiles_container_->child_at(selected_index())->OnKeyPressed(event))
Question: Does this mean the all apps button will work now if you hit enter? Or
not.

If true, then I think you should fix SpokenFeedbackTest (pseudo-revert
https://codereview.chromium.org/762113004/). Or I can do that in a follow-up CL.
(If the all apps button doesn't work, then I will fix that and revert the test
in a follow-up.)

https://codereview.chromium.org/730343008/diff/1/ui/app_list/views/start_page...
ui/app_list/views/start_page_view.cc:194: OnContainerSelected(dir == -1);
I don't really get why you use OnContainerSelected here. I thought OCS was for a
parent container to start moving into this container. But SPV doesn't have a
parent container. You're essentially just using this to get out of an invalid
state (which is unclear to me why you'd be in it). Why should you come up from
the bottom if you were in an invalid state and pressed left?

https://codereview.chromium.org/730343008/diff/1/ui/app_list/views/start_page...
ui/app_list/views/start_page_view.cc:247: return display_results.size() + 1;
Is this result unrelated?

[calamity, 2014-12-10 04:33:45]

Patchset #2 (id:20001) has been deleted

[calamity, 2014-12-10 04:39:18]

Patchset #2 (id:40001) has been deleted

[calamity, 2014-12-10 04:39:47]

https://codereview.chromium.org/730343008/diff/1/ui/app_list/views/start_page...
File ui/app_list/views/start_page_view.cc (right):

https://codereview.chromium.org/730343008/diff/1/ui/app_list/views/start_page...
ui/app_list/views/start_page_view.cc:169:
tiles_container_->child_at(selected_index())->OnKeyPressed(event))
On 2014/12/09 08:02:01, Matt Giuca wrote:
> Question: Does this mean the all apps button will work now if you hit enter?
Or
> not.
> 

Yes.

> If true, then I think you should fix SpokenFeedbackTest (pseudo-revert
> https://codereview.chromium.org/762113004/). Or I can do that in a follow-up
CL.
> (If the all apps button doesn't work, then I will fix that and revert the test
> in a follow-up.)

It wouldn't be a pseudo-revert, you'd need to actually go and select it and
stuff first, changing the things that are in the utterance queue.

https://codereview.chromium.org/730343008/diff/1/ui/app_list/views/start_page...
ui/app_list/views/start_page_view.cc:194: OnContainerSelected(dir == -1);
On 2014/12/09 08:02:01, Matt Giuca wrote:
> I don't really get why you use OnContainerSelected here. I thought OCS was for
a
> parent container to start moving into this container. But SPV doesn't have a
> parent container. You're essentially just using this to get out of an invalid
> state (which is unclear to me why you'd be in it). Why should you come up from
> the bottom if you were in an invalid state and pressed left?

Eh. This is a bit of a semantic choice. I guess we can just put the
functionality here.

FYI, the state is invalid when there's no selection. i.e, on initialization.

https://codereview.chromium.org/730343008/diff/1/ui/app_list/views/start_page...
ui/app_list/views/start_page_view.cc:247: return display_results.size() + 1;
On 2014/12/09 08:02:01, Matt Giuca wrote:
> Is this result unrelated?

Nope. Necessary to allow the all_apps_button_ to be a valid selection index.

[Matt Giuca, 2014-12-10 07:04:28]

lgtm

https://codereview.chromium.org/730343008/diff/1/ui/app_list/views/start_page...
File ui/app_list/views/start_page_view.cc (right):

https://codereview.chromium.org/730343008/diff/1/ui/app_list/views/start_page...
ui/app_list/views/start_page_view.cc:169:
tiles_container_->child_at(selected_index())->OnKeyPressed(event))
OK I will do it.

[calamity, 2014-12-10 08:07:30]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-12-10 08:08:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/730343008/60001

[commit-bot: I haz the power, 2014-12-10 08:10:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-10 08:11:00]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/92233)

[calamity, 2014-12-11 05:54:11]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-12-11 05:54:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/730343008/60001

[commit-bot: I haz the power, 2014-12-11 06:47:37]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2014-12-11 06:48:22]

Patchset 2 (id:??) landed as
https://crrev.com/fe62ca8a995c9ded8d985511b403a5c7ff79c8d8
Cr-Commit-Position: refs/heads/master@{#307873}