Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 730343003: Fix memory leak in nanobench (Closed)

Created:
6 years, 1 month ago by robertphillips
Modified:
6 years, 1 month ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix memory leak in nanobench This is cleanup for (Add MultiPictureDraw to nanobench - https://codereview.chromium.org/731973005/) Committed: https://skia.googlesource.com/skia/+/186a08ed72749976b533efe7abec062e20c48bda

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M bench/SKPBench.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
robertphillips
6 years, 1 month ago (2014-11-21 14:32:44 UTC) #2
jvanverth1
lgtm
6 years, 1 month ago (2014-11-21 14:33:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730343003/1
6 years, 1 month ago (2014-11-21 14:34:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1127)
6 years, 1 month ago (2014-11-21 14:37:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730343003/1
6 years, 1 month ago (2014-11-21 14:47:29 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 14:53:03 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/186a08ed72749976b533efe7abec062e20c48bda

Powered by Google App Engine
This is Rietveld 408576698