Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 730263002: Follow up to a6675a5, make similar changes in .gn files (Closed)

Created:
6 years, 1 month ago by scottmg
Modified:
6 years, 1 month ago
Reviewers:
brettw, jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Follow up to a6675a5, make similar changes in .gn files - Disable 4996 in GN build - Fix lib dir for 8.1 sdk. R=jam@chromium.org TBR=brettw@chromium.org BUG=432748 Committed: https://crrev.com/2d4f994b47e47117072a692291bd2dc77ba497f8 Cr-Commit-Position: refs/heads/master@{#304514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M build/config/compiler/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M build/config/win/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
scottmg
6 years, 1 month ago (2014-11-17 22:24:22 UTC) #1
jam
lgtm, thanks
6 years, 1 month ago (2014-11-17 22:25:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730263002/1
6 years, 1 month ago (2014-11-17 22:28:47 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/24754)
6 years, 1 month ago (2014-11-17 22:37:10 UTC) #6
scottmg
tbr brettw for gn
6 years, 1 month ago (2014-11-17 22:39:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730263002/1
6 years, 1 month ago (2014-11-17 22:40:58 UTC) #10
brettw
lgtm
6 years, 1 month ago (2014-11-17 22:41:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-17 23:17:35 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 23:18:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d4f994b47e47117072a692291bd2dc77ba497f8
Cr-Commit-Position: refs/heads/master@{#304514}

Powered by Google App Engine
This is Rietveld 408576698