Issue 730253002: Sky: Change iframe positioning to use absoluteContentBox for the View's

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 730253002: Sky: Change iframe positioning to use absoluteContentBox for the View's (Closed)

Created:
6 years, 1 month ago by Matt Perry

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Sky: Change iframe positioning to use absoluteContentBox for the View's coordinate system. This fixes a bug where the iframe's view would be positioned incorrectly if there were elements above it. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b23a4893c7b854241b43957539a8ba7a780efd45

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -8 lines)			Patch
M	sky/engine/core/rendering/RenderIFrame.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/tests/lowlevel/iframe.sky	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	sky/tests/lowlevel/iframe-expected.txt	View	1 2	1 chunk	+18 lines, -6 lines	0 comments	Download

Total messages: 5 (1 generated)

esprehn

This should also fix the bug where if you add a border you'd position the ...

6 years, 1 month ago (2014-11-17 22:24:33 UTC) #3

Matt Perry

On 2014/11/17 22:24:33, esprehn wrote: > This should also fix the bug where if you ...

6 years, 1 month ago (2014-11-17 22:37:14 UTC) #4

Matt Perry

6 years, 1 month ago (2014-11-17 22:38:30 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
b23a4893c7b854241b43957539a8ba7a780efd45 (presubmit successful).