Experimental lexer generator: random refactoring + comments.

tools/lexer_generator/dfa.py

 # Copyright 2013 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 37 matching lines @@
 
   def add_transition(self, key, state):
     assert not self.__transitions.has_key(key)
     self.__transitions[key] = state
 
   def transitions(self):
     return self.__transitions
 
   # TODO abstract state matching
   def __matches(self, match_func, value):
-    f = lambda acc, (k, vs): acc | set([vs]) if match_func(k, value) else acc
+    # f collects states whose corresponding TransitionKey matches 'value'.
+    f = (lambda acc, (key, state):
+           acc | set([state]) if match_func(key, value) else acc)
     matches = reduce(f, self.__transitions.items(), set())
+    # Since this is a dfa, we should have at most one such state. Return it.
     if not matches:
       return None
     assert len(matches) == 1
     return iter(matches).next()
 
-  def char_matches(self, value):
+  def next_state_with_char(self, value):
     return self.__matches(lambda k, v : k.matches_char(v), value)
 
   def key_matches(self, value):
     return self.__matches(lambda k, v : k.is_superset_of_key(v), value)
 
 class Dfa(Automaton):
 
   def __init__(self, start_name, mapping):
     super(Dfa, self).__init__()
     self.__terminal_set = set()
@@ skipping 285 matching lines @@
           elif len(intersection) <= len(difference):
             working_set.add(intersection)
           else:
             working_set.add(difference)
         if old_partitions:
           partitions -= old_partitions
         if new_partitions:
           partitions |= new_partitions
     (start_name, mapping) = self.__merge_partitions(partitions)
     return Dfa(start_name, mapping)