Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 730193003: SkVarAlloc::approxBytesAllocated (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

SkVarAlloc::approxBytesAllocated() This is what I was getting at on the other CL. BUG=skia: Committed: https://skia.googlesource.com/skia/+/f27f1bcce50c8f95aea8469684a70b70c9baee09 CQ_EXTRA_TRYBOTS=client.skia.android:Test-Android-Nexus5-Adreno330-Arm7-Release-Trybot Committed: https://skia.googlesource.com/skia/+/0bd57b2e1eb6ff824ac59a461d1a8aa24a808886

Patch Set 1 #

Patch Set 2 : win include #

Patch Set 3 : add debugging, make assert simpler #

Patch Set 4 : duh #

Patch Set 5 : disable assert #

Patch Set 6 : dlmalloc_usable_size #

Patch Set 7 : Skip Android instead. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -3 lines) Patch
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkVarAlloc.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkVarAlloc.cpp View 1 2 3 4 6 2 chunks +24 lines, -3 lines 0 comments Download
A tests/VarAllocTest.cpp View 1 2 3 4 5 6 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (12 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730193003/1
6 years, 1 month ago (2014-11-18 14:25:48 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-18 14:25:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730193003/20001
6 years, 1 month ago (2014-11-18 14:28:29 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-18 14:28:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/741)
6 years, 1 month ago (2014-11-18 14:34:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730193003/40001
6 years, 1 month ago (2014-11-18 14:57:42 UTC) #10
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-18 14:57:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730193003/60001
6 years, 1 month ago (2014-11-18 15:10:49 UTC) #14
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-18 15:10:51 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/768)
6 years, 1 month ago (2014-11-18 15:12:50 UTC) #17
reed1
lgtm
6 years, 1 month ago (2014-11-18 15:13:13 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730193003/80001
6 years, 1 month ago (2014-11-18 15:16:49 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/f27f1bcce50c8f95aea8469684a70b70c9baee09
6 years, 1 month ago (2014-11-18 15:24:19 UTC) #22
mtklein
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/741443002/ by mtklein@google.com. ...
6 years, 1 month ago (2014-11-18 16:12:43 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730193003/100001
6 years, 1 month ago (2014-11-18 16:31:01 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730193003/120001
6 years, 1 month ago (2014-11-18 16:43:02 UTC) #28
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 17:32:43 UTC) #29
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/0bd57b2e1eb6ff824ac59a461d1a8aa24a808886

Powered by Google App Engine
This is Rietveld 408576698