Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 730183005: [turbofan] Recognize sign extension of 8-bit and 16-bit values on arm64. (Closed)

Created:
6 years, 1 month ago by baptiste.afsa1
Modified:
6 years ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] Recognize sign extension of 8-bit and 16-bit values on arm64. R=bmeurer@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
baptiste.afsa1
PTAL
6 years, 1 month ago (2014-11-21 13:35:35 UTC) #1
Benedikt Meurer
LGTM
6 years ago (2014-11-24 05:35:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730183005/1
6 years ago (2014-11-24 10:32:32 UTC) #9
commit-bot: I haz the power
6 years ago (2014-11-24 11:00:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698