Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 730183003: Revert of Attempt #4 to convert telemetry to the typ framework. (Closed)

Created:
6 years, 1 month ago by tommycli
Modified:
6 years, 1 month ago
Reviewers:
Dirk Pranke, dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Attempt #4 to convert telemetry to the typ framework. (patchset #2 id:20001 of https://codereview.chromium.org/743463003/) Reason for revert: Sorry, this broke the bot: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/16871 Original issue's description: > Attempt #4 to convert telemetry to the typ framework. > > This switches telemetry to use the typ python testing framework, > which should allow us to run tests in parallel. > > The prior attempt was foiled by tools/chrome_proxy not having been > updated; this attempt includes that change. > > R=dtu@chromium.org > BUG=388256 > = > > Committed: https://crrev.com/9af6a9ac4b74e30551554793991a1e99db82aa66 > Cr-Commit-Position: refs/heads/master@{#304878} TBR=dtu@chromium.org,dpranke@chromium.org NOTREECHECKS=true NOTRY=true BUG=388256 Committed: https://crrev.com/90a150fcb844f82fb60a4936ef4c6a45002c142c Cr-Commit-Position: refs/heads/master@{#304935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+535 lines, -329 lines) Patch
M tools/chrome_proxy/run_tests View 1 chunk +11 lines, -14 lines 0 comments Download
M tools/perf/run_tests View 1 chunk +10 lines, -14 lines 0 comments Download
M tools/telemetry/PRESUBMIT.py View 1 chunk +1 line, -3 lines 0 comments Download
M tools/telemetry/bootstrap_deps View 1 chunk +30 lines, -17 lines 0 comments Download
M tools/telemetry/run_tests View 1 chunk +8 lines, -13 lines 0 comments Download
M tools/telemetry/telemetry/decorators.py View 3 chunks +16 lines, -64 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/browser_test_case.py View 1 chunk +14 lines, -35 lines 0 comments Download
A tools/telemetry/telemetry/unittest_util/json_results.py View 1 chunk +247 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/run_chromeos_tests.py View 2 chunks +26 lines, -18 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/run_tests.py View 3 chunks +154 lines, -126 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/run_tests_unittest.py View 2 chunks +17 lines, -17 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 4 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tommycli
Created Revert of Attempt #4 to convert telemetry to the typ framework.
6 years, 1 month ago (2014-11-19 23:55:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730183003/1
6 years, 1 month ago (2014-11-19 23:56:46 UTC) #2
commit-bot: I haz the power
Failed to apply patch for tools/chrome_proxy/run_tests: While running git apply --index -3 -p1; error: patch ...
6 years, 1 month ago (2014-11-19 23:58:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730183003/1
6 years, 1 month ago (2014-11-20 00:04:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 00:06:11 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 00:06:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90a150fcb844f82fb60a4936ef4c6a45002c142c
Cr-Commit-Position: refs/heads/master@{#304935}

Powered by Google App Engine
This is Rietveld 408576698