Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 730173002: Switch the Mac build from 32-bit to 64-bit. (Closed)

Created:
6 years, 1 month ago by Robert Sesek
Modified:
6 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, David Yen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Switch the Mac build from 32-bit to 64-bit. As of M39, Chrome is a 64-bit only binary. This changes the default build configuration to 64-bit globally. After this CL, the 32-bit Mac build is no longer supported. BUG=405542, 18323 R=mark@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/602b4bf2748b43b9cb697b039a35131b9e0c913c

Patch Set 1 #

Patch Set 2 : Roll NaCl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
I thought about hard-coding x64 for Mac, but since any Mac that reports ia32 host_arch ...
6 years, 1 month ago (2014-11-17 21:34:44 UTC) #1
Mark Mentovai
LGTM
6 years, 1 month ago (2014-11-17 22:30:33 UTC) #2
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/602b4bf2748b43b9cb697b039a35131b9e0c913c Cr-Commit-Position: refs/heads/master@{#305043}
6 years, 1 month ago (2014-11-20 18:39:07 UTC) #3
Robert Sesek
6 years, 1 month ago (2014-11-20 18:39:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
602b4bf2748b43b9cb697b039a35131b9e0c913c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698